Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace existing tabs implementation with the new ADS components #37647

Closed
6 tasks done
Tracked by #37342
ankitakinger opened this issue Nov 22, 2024 · 1 comment · Fixed by #38989
Closed
6 tasks done
Tracked by #37342

Replace existing tabs implementation with the new ADS components #37647

ankitakinger opened this issue Nov 22, 2024 · 1 comment · Fixed by #38989
Assignees
@alex-golovanov
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

ankitakinger commented Nov 22, 2024 •
edited by alex-golovanov
Loading

  • Replace left control
  • Replace right control
  • Replace tabs list
  • Replace onTabClick
  • Replace onAddButtonClick
  • Replace onCloseTabClick
@ankitakinger ankitakinger mentioned this issue Nov 22, 2024
Open
1 task
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Nov 22, 2024
@ankitakinger ankitakinger changed the title Abstract out pageId in navigation Abstract out pageId in navigation Nov 22, 2024
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Nov 22, 2024
@ankitakinger ankitakinger changed the title Abstract out pageId in navigation Abstract out pageId in tab navigation (onClick prop) Nov 25, 2024
@ankitakinger ankitakinger changed the title Abstract out pageId in tab navigation (onClick prop) Replace existing tabs implementation with the new ADS components Dec 24, 2024
@hetunandu
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @alex-golovanov @ankitakinger

@alex-golovanov alex-golovanov mentioned this issue Feb 3, 2025
Merged
2 tasks
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@alex-golovanov @coderabbitai
chore: entity tabs replacement (appsmithorg#38989)
bdc33fe 
## Description
Replacing entity tab bar and components with ADS templates.


Fixes appsmithorg#37647
Fixes appsmithorg#37775

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13172995565>
> Commit: f3db2d9
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13172995565&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 06 Feb 2025 07:56:59 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced tab interaction: The add button now supports dynamic
visibility and a loading indicator when new tabs are being created.
- Improved editing: Tab labels now feature refined controls for entering
and exiting edit mode, offering a more flexible user experience.
	- New `EntityTabsHeader` component added to enhance tab management.
- Updated tab structure to utilize `DismissibleTab` for improved
functionality.
- Introduced new props for `DismissibleTabBar` to allow for additional
styling and control over add button visibility.
- New properties added to `DismissibleTab` for greater interactivity and
customization.
- Additional properties introduced to `EditableDismissibleTab` for
enhanced editing capabilities.

- **Refactor**
- Streamlined the tab interface by replacing legacy components with
modern, responsive alternatives, simplifying the overall design and
interaction.
- Enhanced event handling and state management for better performance
and user experience.
- Updated import paths and component structures for clarity and
maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-golovanov alex-golovanov

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: entity tabs replacement appsmithorg/appsmith
4 participants
@alex-golovanov @Nikhil-Nandagopal @hetunandu @ankitakinger