Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: When switching segments, the context of the body in APIs is lost #36984

Closed
1 task done
kocharrahul7 opened this issue Oct 21, 2024 · 0 comments · Fixed by #37150
Closed
1 task done

[Bug]: When switching segments, the context of the body in APIs is lost #36984

kocharrahul7 opened this issue Oct 21, 2024 · 0 comments · Fixed by #37150
Assignees
@hetunandu @kocharrahul7 @rohan-arthur
Labels
Bug Something isn't working Entity Explorer Issues related to navigation using the entity explorer IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Integrations Product Issues related to a specific integration Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Query Forms Isuses related to the query forms Query & JS Pod Issues related to the query & JS Pod

Comments

@kocharrahul7
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

When I configure a query body, then switch from queries to any other segment, and return, the context of the selected segment is no longer retained.
This is incredibly annoying while editing the query, and makes me feel like there may be issues in execution since the query configuration seems to not be retained

Steps To Reproduce

  1. Configure the body of an API query
  2. Navigate to a different segment in full screen or in side by side mode
  3. Return to the queries segment. You will still be on the body tab, but the dropdown will rever to none
Screen.Recording.2024-10-21.at.11.27.01.AM.mov

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

v1.46.0
@kocharrahul7 kocharrahul7 added Bug Something isn't working Entity Explorer Issues related to navigation using the entity explorer Needs Triaging Needs attention from maintainers to triage Query Forms Isuses related to the query forms IDE Navigation Issues/feature requests related to IDE navigation, and context switching labels Oct 21, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Medium Issues that frustrate users due to poor UX Production labels Oct 21, 2024
@github-actions github-actions bot added IDE Product Issues related to the IDE Product Integrations Product Issues related to a specific integration IDE Pod Issues that new developers face while exploring the IDE Query & JS Pod Issues related to the query & JS Pod labels Oct 21, 2024
@hetunandu hetunandu self-assigned this Oct 22, 2024
@hetunandu hetunandu mentioned this issue Oct 31, 2024
Merged
2 tasks
hetunandu added a commit that referenced this issue Nov 1, 2024
@hetunandu
fix: API Body format focus retention (#37150)
9a9a7c4 
## Description


- Use Focus retention to store user context of the POST body format of
APIs
- Update component to use hooks instead of redux connect hoc
- remove need of passing Action ID in form data as it is redundant for
focus retention states


Fixes #36984

## Automation

/ok-to-test tags="@tag.Datasource, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11609483418>
> Commit: a3a1a59
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11609483418&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource, @tag.IDE`
> Spec:
> <hr>Thu, 31 Oct 2024 10:31:09 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced a streamlined method for managing API body content types
and form data.
- Added new action creator `setExtraFormData` for enhanced form data
handling.

- **Improvements**
- Simplified the `PostBodyData` component by utilizing React hooks for
state management.
- Updated selectors and reducers to support a flatter structure for form
data, improving clarity and maintainability.

- **Updates**
- Enhanced focus elements configuration to better manage plugin action
form data within the application.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@appsmith-bot appsmith-bot added the QA Needs QA attention label Nov 1, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Nov 1, 2024
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Nov 20, 2024
@hetunandu
fix: API Body format focus retention (appsmithorg#37150)
69aec38 
## Description


- Use Focus retention to store user context of the POST body format of
APIs
- Update component to use hooks instead of redux connect hoc
- remove need of passing Action ID in form data as it is redundant for
focus retention states


Fixes appsmithorg#36984

## Automation

/ok-to-test tags="@tag.Datasource, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11609483418>
> Commit: a3a1a59
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11609483418&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource, @tag.IDE`
> Spec:
> <hr>Thu, 31 Oct 2024 10:31:09 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced a streamlined method for managing API body content types
and form data.
- Added new action creator `setExtraFormData` for enhanced form data
handling.

- **Improvements**
- Simplified the `PostBodyData` component by utilizing React hooks for
state management.
- Updated selectors and reducers to support a flatter structure for form
data, improving clarity and maintainability.

- **Updates**
- Enhanced focus elements configuration to better manage plugin action
form data within the application.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

@kocharrahul7 kocharrahul7

@rohan-arthur rohan-arthur

Labels
Bug Something isn't working Entity Explorer Issues related to navigation using the entity explorer IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Integrations Product Issues related to a specific integration Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Query Forms Isuses related to the query forms Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: API Body format focus retention appsmithorg/appsmith
7 participants
@Nikhil-Nandagopal @hetunandu @pranavkanade @kocharrahul7 @appsmith-bot @rohan-arthur @carinanfonseca