Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: On invoking the datasource - the structure api call is made twice. #36349

Open
1 task done
btsgh opened this issue Sep 16, 2024 · 0 comments
Open
1 task done

[Bug]: On invoking the datasource - the structure api call is made twice. #36349

btsgh opened this issue Sep 16, 2024 · 0 comments
Assignees
@sneha122
Labels
Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Product Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Query & JS Pod Issues related to the query & JS Pod

Comments

@btsgh
Copy link
Collaborator

btsgh commented Sep 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

When I add a database, say movies mock db, the structure api call is made twice. This call should be made only once.

Steps To Reproduce

  1. With the network tab open, create a new workspace
  2. Click on Data and create a new datasource
  3. Select movies. Filter for struct in the network tab
  4. Note that the datasource structure api is called twice.
    Expected behavior - It should be called only once

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

https://jam.dev/c/afe345ed-1a7a-4f7b-8bb1-105715427ff3

Version

Cloud
@btsgh btsgh added Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Production Needs Triaging Needs attention from maintainers to triage Medium Issues that frustrate users due to poor UX labels Sep 16, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Low An issue that is neither critical nor breaks a user flow label Sep 16, 2024
@github-actions github-actions bot added Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod labels Sep 16, 2024
@NandanAnantharamu NandanAnantharamu mentioned this issue Sep 16, 2024
Merged
NandanAnantharamu added a commit that referenced this issue Sep 16, 2024
@NandanAnantharamu
test: fix DataSourceScheme (#36339)
5dfbe8c 
test:
Fixing DataSourceScheme test

EE PR: appsmithorg/appsmith-ee#5155

Improved reliability of data source schema tests by ensuring correct UI
interactions and logical flow.
Enhanced verification process by checking for the absence of loading
spinners before data verification.

**Bugs Raised as part of fixing the spec:**

#36349
Test Skipped: #36348

/ok-to-test tags="@tag.All"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10885399399>
> Commit: 12ca3b6
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10885399399&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 16 Sep 2024 15:08:37 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Bug Fixes**
- Skipped a test case for schema fetching due to a known bug, improving
test reliability.
  
- **New Features**
- Enhanced search functionality within the datasource structure,
ensuring previous inputs do not interfere with new searches.
- Improved interaction with the schema tab in the user interface for
better testing.

- **Documentation**
- Updated the path for limited tests to focus on the "Datasource Schema"
functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “NandanAnantharamu” <“[email protected]”>
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@NandanAnantharamu @Shivam-z
test: fix DataSourceScheme (appsmithorg#36339)
52ab83c 
test:
Fixing DataSourceScheme test

EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5155

Improved reliability of data source schema tests by ensuring correct UI
interactions and logical flow.
Enhanced verification process by checking for the absence of loading
spinners before data verification.

**Bugs Raised as part of fixing the spec:**

appsmithorg#36349
Test Skipped: appsmithorg#36348

/ok-to-test tags="@tag.All"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10885399399>
> Commit: 12ca3b6
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10885399399&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 16 Sep 2024 15:08:37 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Bug Fixes**
- Skipped a test case for schema fetching due to a known bug, improving
test reliability.
  
- **New Features**
- Enhanced search functionality within the datasource structure,
ensuring previous inputs do not interfere with new searches.
- Improved interaction with the schema tab in the user interface for
better testing.

- **Documentation**
- Updated the path for limited tests to focus on the "Datasource Schema"
functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “NandanAnantharamu” <“[email protected]”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sneha122 sneha122

Labels
Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Product Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nikhil-Nandagopal @sneha122 @btsgh