Skip to content

Commit

Permalink
chore: fix wds select widget bugs + refactor (#38304)
Browse files Browse the repository at this point in the history
Fixes #38197 

/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced styling for select input components, improving visual
consistency.
- Introduced new validation functions for widget properties, ensuring
better data integrity.
- Added properties for improved configuration of select widgets,
including dynamic data binding.
- New utility functions for handling options in select widgets,
enhancing functionality.
- Introduced a constant for sample data to facilitate testing and
development.

- **Bug Fixes**
- Resolved issues with widget rendering and responsiveness to property
changes.

- **Refactor**
- Streamlined widget implementation by leveraging inherited
functionalities and simplifying methods.
- Updated methods to improve handling of derived properties and options.
- Removed obsolete configuration files and validation functions to clean
up the codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12480977859>
> Commit: d669e05
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12480977859&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Tue, 24 Dec 2024 11:43:59 UTC
<!-- end of auto-generated comment: Cypress test results  -->
  • Loading branch information
jsartisan authored Dec 24, 2024
1 parent d9a3253 commit ecf9934
Show file tree
Hide file tree
Showing 32 changed files with 712 additions and 981 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,7 @@ button.selectTriggerButton {
align-items: center;
flex: 1;
}

.selectTriggerButton [data-select-text][data-placeholder] {
color: var(--color-fg-neutral-subtle);
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit ecf9934

Please sign in to comment.