fix: code review comments

appsmithorg · Nov 6, 2024 · 9fbde99 · 9fbde99
1 parent ed54f78
commit 9fbde99
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/...psmith-server/src/test/java/com/appsmith/server/services/ActionCollectionServiceTest.java b/...psmith-server/src/test/java/com/appsmith/server/services/ActionCollectionServiceTest.java
@@ -74,6 +74,7 @@
 import static com.appsmith.server.constants.FieldName.VIEWER;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 
 @SpringBootTest
 @Slf4j
@@ -793,6 +794,13 @@ public void testDeleteActionCollection_afterApplicationPublish_clearsActionColle
                     assertEquals(
                             AppsmithError.CYCLICAL_DEPENDENCY_ERROR.getAppErrorCode(),
                             actionCollectionDTO1.getErrorReports().get(0).getCode());
+
+                    // Iterate over each action and assert that errorReports is null as action collection already has
+                    // error reports
+                    // it's not required in each action
+                    actionCollectionDTO
+                            .getActions()
+                            .forEach(action -> assertNull(action.getErrorReports(), "Error reports should be null"));
                 })
                 .verifyComplete();
     }