Restore data-testid attributes & update unit tests.

appsmithorg · Feb 4, 2025 · 4c80891 · 4c80891
1 parent c92bef9
commit 4c80891
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 2 deletions.
diff --git a/app/client/packages/design-system/ads/src/DismissibleTab/DismissibleTabBar.tsx b/app/client/packages/design-system/ads/src/DismissibleTab/DismissibleTabBar.tsx
@@ -107,6 +107,7 @@ export const DismissibleTabBar = ({
             <Spinner size="md" />
           ) : (
             <Styled.PlusButton
+              data-testid="t--ide-tabs-add-button"
               isDisabled={disableAdd}
               isIconButton
               kind="tertiary"

diff --git a/app/client/src/pages/Editor/IDE/EditorTabs/AddTab.tsx b/app/client/src/pages/Editor/IDE/EditorTabs/AddTab.tsx
@@ -32,6 +32,7 @@ const AddTab = ({
 
   return (
     <DismissibleTab
+      dataTestId="t--ide-tab-new_query"
       isActive={segmentMode === EditorEntityTabState.Add && !isListActive}
       onClick={newTabClickCallback}
       onClose={onCloseClick}

diff --git a/app/client/src/pages/Editor/IDE/EditorTabs/EditableTab.tsx b/app/client/src/pages/Editor/IDE/EditorTabs/EditableTab.tsx
@@ -9,6 +9,7 @@ import { FEATURE_FLAG } from "ee/entities/FeatureFlag";
 import { getIsSavingEntityName } from "ee/selectors/entitiesSelector";
 
 import { useFeatureFlag } from "utils/hooks/useFeatureFlag";
+import { sanitizeString } from "utils/URLUtils";
 
 import {
   getEditableTabPermissions,
@@ -63,6 +64,7 @@ export function EditableTab(props: EditableTabProps) {
   return (
     <EditableDismissibleTab
       canEdit={isChangePermitted}
+      dataTestId={`t--ide-tab-${sanitizeString(title)}`}
       icon={icon}
       isActive={isActive}
       isEditable={isChangePermitted}

diff --git a/app/client/src/pages/Editor/IDE/EditorTabs/Editortabs.test.tsx b/app/client/src/pages/Editor/IDE/EditorTabs/Editortabs.test.tsx
@@ -44,7 +44,8 @@ describe("EditorTabs render checks", () => {
     // check tabs is empty
     const tabsContainer = getByTestId("t--tabs-container");
 
-    expect(tabsContainer.firstChild).toBeNull();
+    // tabs container contains 2 sentinel divs to check for intersections, so in empty state it should have 2 children
+    expect(tabsContainer.childElementCount).toBe(2);
 
     //check add button is not present
     expect(queryByTestId("t--ide-tabs-add-button")).toBeNull();
@@ -69,7 +70,8 @@ describe("EditorTabs render checks", () => {
     // check tabs is empty
     const tabsContainer = getByTestId("t--tabs-container");
 
-    expect(tabsContainer.firstChild).toBeNull();
+    // tabs container contains 2 sentinel divs to check for intersections, so in empty state it should have 2 children
+    expect(tabsContainer.childElementCount).toBe(2);
 
     //check add button is not present
     expect(queryByTestId("t--ide-tabs-add-button")).toBeNull();

diff --git a/app/client/src/pages/Editor/IDE/EditorTabs/index.tsx b/app/client/src/pages/Editor/IDE/EditorTabs/index.tsx
@@ -93,6 +93,7 @@ const EditorTabs = () => {
       <EntityTabsHeader>
         {showEntityListButton && (
           <EntityListButton
+            data-testid="t--list-toggle"
             isSelected={isListViewActive}
             onClick={handleHamburgerClick}
           />