fix: adding review changes

appsmithorg · Nov 29, 2024 · 3d9de62 · 3d9de62
1 parent dcd6793
commit 3d9de62
Show file tree

Hide file tree

Showing 27 changed files with 104 additions and 64 deletions.
diff --git a/app/client/packages/git/src/actions/checkoutBranchActions.ts b/app/client/packages/git/src/actions/checkoutBranchActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const checkoutBranchInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.checkoutBranch.loading = true;
@@ -17,7 +17,7 @@ export const checkoutBranchSuccessAction = createSingleArtifactAction(
 );
 
 export const checkoutBranchErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.checkoutBranch.loading = false;

diff --git a/app/client/packages/git/src/actions/commitActions.ts b/app/client/packages/git/src/actions/commitActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const commitInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.commit.loading = true;
@@ -15,7 +15,7 @@ export const commitSuccessAction = createSingleArtifactAction((state) => {
 });
 
 export const commitErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.commit.loading = false;

diff --git a/app/client/packages/git/src/actions/connectActions.ts b/app/client/packages/git/src/actions/connectActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const connectInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.connect.loading = true;
@@ -15,7 +15,7 @@ export const connectSuccessAction = createSingleArtifactAction((state) => {
 });
 
 export const connectErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.connect.loading = false;

diff --git a/app/client/packages/git/src/actions/createBranchActions.ts b/app/client/packages/git/src/actions/createBranchActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const createBranchInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.createBranch.loading = true;
@@ -15,7 +15,7 @@ export const createBranchSuccessAction = createSingleArtifactAction((state) => {
 });
 
 export const createBranchErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.createBranch.loading = false;

diff --git a/app/client/packages/git/src/actions/deleteBranchActions.ts b/app/client/packages/git/src/actions/deleteBranchActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const deleteBranchInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.deleteBranch.loading = true;
@@ -15,7 +15,7 @@ export const deleteBranchSuccessAction = createSingleArtifactAction((state) => {
 });
 
 export const deleteBranchErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.deleteBranch.loading = false;

diff --git a/app/client/packages/git/src/actions/discardActions.ts b/app/client/packages/git/src/actions/discardActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const discardInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.discard.loading = true;
@@ -15,7 +15,7 @@ export const discardSuccessAction = createSingleArtifactAction((state) => {
 });
 
 export const discardErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.discard.loading = false;

diff --git a/app/client/packages/git/src/actions/disconnectActions.ts b/app/client/packages/git/src/actions/disconnectActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const disconnectInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.disconnect.loading = true;
@@ -15,7 +15,7 @@ export const disconnectSuccessAction = createSingleArtifactAction((state) => {
 });
 
 export const disconnectErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.disconnect.loading = false;

diff --git a/app/client/packages/git/src/actions/fetchAutocommitProgressActions.ts b/app/client/packages/git/src/actions/fetchAutocommitProgressActions.ts
@@ -1,4 +1,8 @@
-import type { GitArtifactPayloadAction, GitAutocommitProgress } from "../types";
+import type {
+  GitArtifactPayloadAction,
+  GitArtifactErrorPayloadAction,
+  GitAutocommitProgress,
+} from "../types";
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
 
 export const fetchAutocommitProgressInitAction = createSingleArtifactAction(
@@ -26,7 +30,7 @@ export const fetchAutocommitProgressSuccessAction = createSingleArtifactAction(
 );
 
 export const fetchAutocommitProgressErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.autocommitProgress.loading = false;

diff --git a/app/client/packages/git/src/actions/fetchBranchesActions.ts b/app/client/packages/git/src/actions/fetchBranchesActions.ts
@@ -1,4 +1,8 @@
-import type { GitArtifactPayloadAction, GitBranches } from "../types";
+import type {
+  GitArtifactPayloadAction,
+  GitArtifactErrorPayloadAction,
+  GitBranches,
+} from "../types";
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
 
 export const fetchBranchesInitAction = createSingleArtifactAction((state) => {
@@ -18,7 +22,7 @@ export const fetchBranchesSuccessAction = createSingleArtifactAction(
 );
 
 export const fetchBranchesErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.branches.loading = false;

diff --git a/app/client/packages/git/src/actions/fetchGlobalConfigActions.ts b/app/client/packages/git/src/actions/fetchGlobalConfigActions.ts
@@ -1,4 +1,8 @@
-import type { GitArtifactPayloadAction, GitGlobalConfig } from "../types";
+import type {
+  GitArtifactPayloadAction,
+  GitArtifactErrorPayloadAction,
+  GitGlobalConfig,
+} from "../types";
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
 
 export const fetchGlobalConfigInitAction = createSingleArtifactAction(
@@ -23,7 +27,7 @@ export const fetchGlobalConfigSuccessAction = createSingleArtifactAction(
 );
 
 export const fetchGlobalConfigErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.globalConfig.loading = false;

diff --git a/app/client/packages/git/src/actions/fetchLocalConfigActions.ts b/app/client/packages/git/src/actions/fetchLocalConfigActions.ts
@@ -1,4 +1,8 @@
-import type { GitArtifactPayloadAction, GitLocalConfig } from "../types";
+import type {
+  GitArtifactPayloadAction,
+  GitArtifactErrorPayloadAction,
+  GitLocalConfig,
+} from "../types";
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
 
 export const fetchLocalConfigInitAction = createSingleArtifactAction(
@@ -23,7 +27,7 @@ export const fetchLocalConfigSuccessAction = createSingleArtifactAction(
 );
 
 export const fetchLocalConfigErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.localConfig.loading = false;

diff --git a/app/client/packages/git/src/actions/fetchMergeStatusActions.ts b/app/client/packages/git/src/actions/fetchMergeStatusActions.ts
@@ -1,4 +1,8 @@
-import type { GitArtifactPayloadAction, GitMergeStatus } from "../types";
+import type {
+  GitArtifactPayloadAction,
+  GitArtifactErrorPayloadAction,
+  GitMergeStatus,
+} from "../types";
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
 
 export const fetchMergeStatusInitAction = createSingleArtifactAction(
@@ -23,7 +27,7 @@ export const fetchMergeStatusSuccessAction = createSingleArtifactAction(
 );
 
 export const fetchMergeStatusErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.mergeStatus.loading = false;

diff --git a/app/client/packages/git/src/actions/fetchMetadataActions.ts b/app/client/packages/git/src/actions/fetchMetadataActions.ts
@@ -1,4 +1,8 @@
-import type { GitArtifactPayloadAction, GitMetadata } from "../types";
+import type {
+  GitArtifactPayloadAction,
+  GitArtifactErrorPayloadAction,
+  GitMetadata,
+} from "../types";
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
 
 export const fetchMetadataInitAction = createSingleArtifactAction((state) => {
@@ -18,7 +22,7 @@ export const fetchMetadataSuccessAction = createSingleArtifactAction(
 );
 
 export const fetchMetadataErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.metadata.loading = false;

diff --git a/app/client/packages/git/src/actions/fetchProtectedBranchesActions.ts b/app/client/packages/git/src/actions/fetchProtectedBranchesActions.ts
@@ -1,4 +1,8 @@
-import type { GitArtifactPayloadAction, GitProtectedBranches } from "../types";
+import type {
+  GitArtifactPayloadAction,
+  GitArtifactErrorPayloadAction,
+  GitProtectedBranches,
+} from "../types";
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
 
 export const fetchProtectedBranchesInitAction = createSingleArtifactAction(
@@ -26,7 +30,7 @@ export const fetchProtectedBranchesSuccessAction = createSingleArtifactAction(
 );
 
 export const fetchProtectedBranchesErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.protectedBranches.loading = false;

diff --git a/app/client/packages/git/src/actions/fetchSSHKeyActions.ts b/app/client/packages/git/src/actions/fetchSSHKeyActions.ts
@@ -1,4 +1,8 @@
-import type { GitArtifactPayloadAction, GitSSHKey } from "../types";
+import type {
+  GitArtifactPayloadAction,
+  GitArtifactErrorPayloadAction,
+  GitSSHKey,
+} from "../types";
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
 
 export const fetchSSHKeyInitAction = createSingleArtifactAction((state) => {
@@ -18,7 +22,7 @@ export const fetchSSHKeySuccessAction = createSingleArtifactAction(
 );
 
 export const fetchSSHKeyErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.sshKey.loading = false;

diff --git a/app/client/packages/git/src/actions/fetchStatusActions.ts b/app/client/packages/git/src/actions/fetchStatusActions.ts
@@ -1,4 +1,8 @@
-import type { GitArtifactPayloadAction, GitStatus } from "../types";
+import type {
+  GitArtifactPayloadAction,
+  GitArtifactErrorPayloadAction,
+  GitStatus,
+} from "../types";
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
 
 export const fetchStatusInitAction = createSingleArtifactAction((state) => {
@@ -18,7 +22,7 @@ export const fetchStatusSuccessAction = createSingleArtifactAction(
 );
 
 export const fetchStatusErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.status.loading = false;

diff --git a/app/client/packages/git/src/actions/generateSSHKey.ts b/app/client/packages/git/src/actions/generateSSHKey.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const generateSSHKeyInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.generateSSHKey.loading = true;
@@ -17,7 +17,7 @@ export const generateSSHKeySuccessAction = createSingleArtifactAction(
 );
 
 export const generateSSHKeyErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.generateSSHKey.loading = false;

diff --git a/app/client/packages/git/src/actions/helpers/singleArtifactInitialState.ts b/app/client/packages/git/src/actions/helpers/singleArtifactInitialState.ts
@@ -13,22 +13,22 @@ import type {
 const gitSingleArtifactInitialUIState: GitSingleArtifactUIReduxState = {
   connectModal: {
     open: false,
-    step: GitConnectStep.provider,
+    step: GitConnectStep.Provider,
   },
   importModal: {
     open: false,
-    step: GitImportStep.provider,
+    step: GitImportStep.Provider,
   },
   branchList: {
     open: false,
   },
   opsModal: {
     open: false,
-    tab: GitOpsTab.deploy,
+    tab: GitOpsTab.Deploy,
   },
   settingsModal: {
     open: false,
-    tab: GitSettingsTab.general,
+    tab: GitSettingsTab.General,
   },
 };
 

diff --git a/app/client/packages/git/src/actions/mergeActions.ts b/app/client/packages/git/src/actions/mergeActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const mergeInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.merge.loading = true;
@@ -15,7 +15,7 @@ export const mergeSuccessAction = createSingleArtifactAction((state) => {
 });
 
 export const mergeErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.merge.loading = false;

diff --git a/app/client/packages/git/src/actions/pullActions.ts b/app/client/packages/git/src/actions/pullActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const pullInitAction = createSingleArtifactAction((state) => {
   state.apiResponses.pull.loading = true;
@@ -15,7 +15,7 @@ export const pullSuccessAction = createSingleArtifactAction((state) => {
 });
 
 export const pullErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.pull.loading = false;

diff --git a/app/client/packages/git/src/actions/toggleAutocommitActions.ts b/app/client/packages/git/src/actions/toggleAutocommitActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const toggleAutocommitInitAction = createSingleArtifactAction(
   (state) => {
@@ -19,7 +19,7 @@ export const toggleAutocommitSuccessAction = createSingleArtifactAction(
 );
 
 export const toggleAutocommitErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.toggleAutocommit.loading = false;

diff --git a/app/client/packages/git/src/actions/triggerAutocommitActions.ts b/app/client/packages/git/src/actions/triggerAutocommitActions.ts
@@ -1,5 +1,5 @@
 import { createSingleArtifactAction } from "./helpers/createSingleArtifactAction";
-import type { GitArtifactPayloadAction } from "../types";
+import type { GitArtifactErrorPayloadAction } from "../types";
 
 export const triggerAutocommitInitAction = createSingleArtifactAction(
   (state) => {
@@ -19,7 +19,7 @@ export const triggerAutocommitSuccessAction = createSingleArtifactAction(
 );
 
 export const triggerAutocommitErrorAction = createSingleArtifactAction(
-  (state, action: GitArtifactPayloadAction<{ error: string }>) => {
+  (state, action: GitArtifactErrorPayloadAction) => {
     const { error } = action.payload;
 
     state.apiResponses.triggerAutocommit.loading = false;