Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the restify package #807

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Add support for the restify package #807

merged 1 commit into from
Nov 30, 2022

Conversation

tombruijn
Copy link
Member

  • Add the OpenTelemetry instrumentation.
  • Add a test app.

Requires an extension updates before it will report any data.

Part of #787

@tombruijn
Add support for the restify package
ae2ea82 
- Add the OpenTelemetry instrumentation.
- Add a test app.

Requires an extension updates before it will report any data.

Part of #787
@tombruijn tombruijn self-assigned this Nov 29, 2022
@tombruijn
Copy link
Member Author

I assume this needs a requestHook config option added upstream to report request params?

luismiramirez
luismiramirez approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@luismiramirez luismiramirez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this needs a requestHook config option added upstream to report request params?

Yes, from what I can see on the official repo, there's no requestHook implemented.

@tombruijn
Copy link
Member Author

I've sent in a PR for the requestHook support. open-telemetry/opentelemetry-js-contrib#1312
I'll create another PR in this repo to support it once it's released.

@tombruijn tombruijn merged commit 8c1bd31 into main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unflxw unflxw unflxw approved these changes

@luismiramirez luismiramirez luismiramirez approved these changes

@jeffkreeftmeijer jeffkreeftmeijer Awaiting requested review from jeffkreeftmeijer

Assignees

@tombruijn tombruijn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tombruijn @luismiramirez @unflxw