Bugfix/progress bar markup #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset includes basic files required for an xblock. Such as: - video_xblock.py with Python side of the VideoXBlock - backends directory with BaseVideoPlayer class and it’s minimal implementation DummyPlayer - student_view.html a template to render video - Documentation in README.md - setup.py with module specifications - bower.json with external JavaScript dependencies - requirements.txt with Python dependencies
- backends/youtube.py is a server-side part responsible for the logic - static/html/youtube.html is a template to render video player - static/css/videojs.css is a video.js skin definition to replicate Open edX video player look
- backends/wistia.py is a server-side part. Prepares context for video player - static/html/wistiavideo.html is a template to render video player
Brightcove video players are special. They are based on a Video.js but are loaded from the player.brightcove.net. Hence we use separate css. - backends/brightcove.py is a server-side part responsible for the logic - static/html/brightcove.html is a template to render video player. Also includes styles for Brightcove’s ‘default’ theme - static/css/brightcove.css is a video.js skin definition to replicate Open edX video player look
To turn on playback rates support for all video.js plugins we patch video.js Tech component.
Playback state includes: - Current time to within 1 second. Unique for each player - Playback rate. Unique for user, shared between players - Volume. Unique for user, shared between players - Muted. Unique for user, shared between players Playback state is loaded after Video.js player is fully initialized and passed from server in the video player’s template at rendering time. Every video player is rendered inside an iframe and doesn’t have access to xblock’s runtime. So they post their state to a parent frame as a message using `Window.postMessage`. Parent frame in turn accepts and verifies the state and post it to the server to a json handler resolved by `runtime.handlerUrl(element, 'save_player_state’)` method. Playback state is being saved at following events: - Volume change - Playback rate change - Play - Pause - Video ended
Progress bar had incorrect position on Safari and IE
bryanlandia
pushed a commit
that referenced
this pull request
Jul 28, 2021
…hanges Brings changes from working branch in raccoongang repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/mqBhfGfO/64-wistia-youtube-ie11-and-safari-and-ff-video-position-slider