fix: YouTube video transcrips Import #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirtds
force-pushed
the
amir/fix/ginkgo-youtube-transcripts
branch
3 times, most recently
from
dd65bfb to
0b164f1
Compare
amirtds
changed the title
johnbaldwin
approved these changes
Mar 2, 2022
|
Is this a fix that should also go into Tahoe? |
|
Thanks @johnbaldwin Yes Tahoe needs a similar fix, but we can't merge this PR to our Juniper branch I need to check changes we had from Ginkgo to Juniper and will open a new PR. |
amirtds
force-pushed
the
amir/fix/ginkgo-youtube-transcripts
branch
from
0b164f1 to
4369535
Compare
OmarIthawi
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Thanks a lot @amirtds! Let me know when you make the Juniper pull request.
I think this is something worth contributing upstream:
- I've added an issue Contribute: YouTube video transcripts Import fix #1094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
https://appsembler.atlassian.net/browse/BLACK-2163
By the end of 2021 YouTube Deprecated their Timedtext API. This caused problem for our customers to download automatically the transcripts for their YouTube video for their videos in Open edX. Open edX team is aware of this error https://openedx.atlassian.net/browse/TNL-9460, but there was no movement on solving this issue from open edx end.
We tried to solve this by replacing the API with a new YouTube API, but the new API requires OAuth authentication and only works with videos in the same channel and even with corresponding changes in the codebase the Transcripts didn't work.
Our solution
I developed a new API that responds with SRT version of transcripts for a given YouTube video ID for example https://us-central1-penn-state.cloudfunctions.net/youtube-transcript?video_id=AcZZlbWRyUM You can try this with different videos just replace what comes after
video_id=with your YouTube video ID.After receiving the Transcripts from our API we make a call to
transcripts/uploadto upload the transcript for a given unit component location, and we store the transcripts. To make it visible in Studio and LMS.The functionality should work as the following video
Filmage.2022-02-28_204527.mp4