Atomic transaction for the migrate_transcripts command
#1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarIthawi
requested review from
estherjsuh,
melvinsoft,
shadinaif and
thraxil
as code owners
This comment has been minimized.
This comment has been minimized.
thraxil
approved these changes
Jan 25, 2022
| @@ -108,8 +108,17 @@ def enqueue_async_migrate_transcripts_tasks(course_keys, | |||
| 'command_run': command_run | |||
| } | |||
|
|
|||
| from django.db import transaction | |||
There was a problem hiding this comment.
should we keep imports together at the top of the file?
There was a problem hiding this comment.
In general yes. I this case, I'm planning to revert this hack entirely, so it's worth to keep everything in a single place.
estherjsuh
approved these changes
Jan 25, 2022
This comment has been minimized.
This comment has been minimized.
OmarIthawi
commented
Mar 1, 2022
OmarIthawi
commented
Mar 1, 2022
This comment has been minimized.
This comment has been minimized.
OmarIthawi
force-pushed
the
atomic_transcript_migrate
branch
from
cabde92 to
133df0a
Compare
This comment has been minimized.
This comment has been minimized.
OmarIthawi
force-pushed
the
atomic_transcript_migrate
branch
from
133df0a to
15c4f1e
Compare
This comment has been minimized.
This comment has been minimized.
- a course will either be successful or will fail in one atomic SQL transaction. - a course failure will be logged, then continue for next course - ItemNotFoundError will be ignored seperately from other errors since it's usually means that we have some other problem that the `migrate_transcripts` command shouldn't worry about
OmarIthawi
force-pushed
the
atomic_transcript_migrate
branch
from
15c4f1e to
d83e6c4
Compare
|
Checking git merge conflicts against https://github.com/edx/edx-platform.git
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A course will either be successful or will fail in one atomic SQL transaction.
Jira: RED-2483.
TODO