Add new var for S3 london bucket if necesary #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarIthawi
approved these changes
Jun 18, 2020
|
@melvinsoft you'd need to add this in the AWS_S3_REGION_NAME = AUTH/ENV_TOKENS.get('AWS_S3_REGION_NAME', '') |
thraxil
approved these changes
Jun 18, 2020
|
@thraxil @OmarIthawi Thanks for the review, the line it's already added in edx platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The course export is broken in the UK cluster because the course file cannot be downloaded from S3, it's returning a signature error.
After been digging in the issue for while looks like Django storages has some issues with EU bucket and some extra and non documented vars are needed. Here is the explanation: jschneier/django-storages#28 (comment)
This PRs works has two companions: appsembler/edx-platform#623 and https://github.com/appsembler/edx-configs/pull/883