Create Test_edge_creation #119

tommykennedy · 2015-07-07T18:08:52Z

Hi Dario

I hope this test is attached now

Tom

EDIT: adds failing test for #116

dmarcelino · 2015-07-08T13:39:43Z

test/integration-orientdb/bugs/Test_Edge_Creation

+
+var self = this;
+
+describe('Issue: Found class name null', function () {


Please replace "Issue:" for "Bug #116:" so it will be listed among the other bugs in the build log, example: https://travis-ci.org/appscot/sails-orientdb/jobs/69971485#L1258

dmarcelino · 2015-07-08T13:44:33Z

Hey @tommykennedy, made few inline comments. Because the file doesn't end with .js it didn't run. Please fix the aforementioned things and commit to the same branch. Cheers

tommykennedy · 2015-07-08T15:27:16Z

I have updated the file with your instructions and appended .js to the filename.

dmarcelino · 2015-07-08T15:31:44Z

So it seems your test is actually passing (https://travis-ci.org/appscot/sails-orientdb/jobs/70070905#L1265):

  Bug #116: Found class name null
    Create answer
  ✓ should add answer and create edge answered from answer to questions (38ms)

Can it be that your model definition is slightly different from the one used in the test?

tommykennedy · 2015-07-08T15:39:33Z

I ran the test on my machine and it fails it with the error.

Im using the following configuration below.

OrientDB Server v2.0.1

"name": "sails-orientdb",
"version": "0.10.55",

dmarcelino · 2015-07-08T15:43:48Z

Can you try upgrading your OrientDB server to v2.0.12 to dismiss any potential OrientDB change?

The only thing that changed in master branch after v0.10.55 was updating dependencies, you can try that locally... but it's unlikely it would cause this issue.

tommykennedy · 2015-07-08T18:23:53Z

I upgraded to 2.0.12 and deleted sails-orientdb and reinstalled it npm install sails-orientdb. The exact output I get is.

Bug Found class name null or empty #116: Found class name null Create answer should add answer and create edge answered from answer to questions:
[Error (E_UNKNOWN) Encountered an unexpected error] Details: OrientDB.RequestError: Found class name null or empty

Error (E_UNKNOWN) :: Encountered an unexpected error
Error (E_UNKNOWN) :: Encountered an unexpected error
OrientDB.RequestError: Found class name null or empty
at readableAddChunk (_stream_readable.js:163:16)
at Socket.Readable.push (_stream_readable.js:126:10)
at TCP.onread (net.js:538:20)

tommykennedy · 2015-07-08T20:03:07Z

I ran the test script on another machine with Orient 2.0.12 and npm install sails-orientdb. I created the test script in /test/integration-orientdb/bugs and executed npm test.

Same error

Did you use the last updated 116-test_edge_creation.js in the test?

tommykennedy · 2015-07-08T20:34:43Z

I figured out how to turn debugging on and the output is below. Im not sure why answer gets an @Class property within the embedded type. Also why is there another type field with value document. I would have expected this to be in the @type field.
E.g
{ Answer: { '@type': 'd', '@Class': '', type: 'document', binary: 'Yes' }

Bug #116: Found class name null
sails-orientdb:adapter:debug registerConnection: db=test_bug_116 , connection=test_bug_116 +2ms
sails-orientdb:connection:info Connecting to database... +0ms
sails-orientdb:edge:debug getEdgeSides: finding vertexes for: answer_question__questions_answers +2ms
sails-orientdb:edge:debug getEdgeSides: match found for answer_question: question +0ms
sails-orientdb:edge:debug getEdgeSides: match found for questions_answers: answers +0ms
sails-orientdb:edge:info Edge [answer_question__questions_answers] has changed its tableName to [answered] +0ms
sails-orientdb:connection:info Database test_bug_116 not found, will create it. +3ms
sails-orientdb:adapter:debug describe: Answer +19ms
sails-orientdb:adapter:debug describe: Answer +1ms
sails-orientdb:adapter:debug define: Answer +0ms
sails-orientdb:adapter:debug describe: Questions +9ms
sails-orientdb:adapter:debug describe: Questions +1ms
sails-orientdb:adapter:debug define: Questions +0ms
sails-orientdb:adapter:debug describe: answer_question__questions_answers +10ms
sails-orientdb:adapter:debug describe: answer_question__questions_answers +0ms
sails-orientdb:adapter:debug define: answer_question__questions_answers +0ms
sails-orientdb:connection:info All classes created, post processing +10ms
Create answer
sails-orientdb:document:debug Insert into [Questions] values: [object Object]
Inspected object #1
{ question: 'This should work, shouldnt it?',
createdAt: Wed Jul 08 2015 21:26:54 GMT+0100 (BST),
updatedAt: Wed Jul 08 2015 21:26:54 GMT+0100 (BST) } +9ms
sails-orientdb:document:debug Insert result id: { cluster: 12, position: 0 } +1ms
sails-orientdb:document:debug Insert into [Answer] values: [object Object]
_Inspected object #1
{ Answer: { binary: 'Yes', '@type': 'd' },
createdAt: Wed Jul 08 2015 21:26:54 GMT+0100 (BST),
updatedAt: Wed Jul 08 2015 21:26:54 GMT+0100 (BST) } +1ms
sails-orientdb:document:debug Insert result id: { cluster: 11, position: 0 } +1ms
sails-orientdb:document:debug Update [Answer] with values: [object Object]
_Inspected object #1
{ Answer: { '@type': 'd', '@Class': '', type: 'document', binary: 'Yes' },
createdAt: Wed Jul 08 2015 21:26:54 GMT+0100 (BST),
updatedAt: Wed Jul 08 2015 21:26:54 GMT+0100 (BST),
'@Rid': '#11:0' } +1ms
sails-orientdb:document:debug Update where query: @Rid = :param0 +0ms
sails-orientdb:document:debug Update params: { param0: { cluster: 11, position: 0 } } +0ms
sails-orientdb:document:error Failed to update, error: OrientDB.RequestError: Found class name null or empty
_Stack trace #1
OrientDB.RequestError: Found class name null or empty

tommykennedy · 2015-07-10T10:53:20Z

Dario

Have you tried running the test script on your local machine? I build passed on travis for me also. Im totally stumped as it has failed on 2 separate machines now.

dmarcelino · 2015-07-10T10:59:35Z

I was just doing that :), the test passed against OrientDB v2.0.10:

  Bug #116: Found class name null or empty
    Create answer
      ✓ should add answer and create edge answered from answer to questions

Which OS are you using btw? My machine is a Mac while travis runs on linux (not sure which).

tommykennedy · 2015-07-10T11:05:14Z

Im running Mac OS X Yosemite 10.10.3

My debug output looks strange.

Let me download 2.0.10 and check that.

dmarcelino · 2015-07-10T11:22:51Z

I'm still on Mavericks but I would be surprised if that was the source of our different results.

Meanwhile I've submitted tommykennedy#1 in an attempt to fix the issue. Can you please try it and report back?

tommykennedy · 2015-07-10T11:29:30Z

Eureka. That fixes it and the edges get created.

There seems to be an extra type property getting added also below
{"@type":"document","@Version":0,"binary":"yes","type":"document"}

Could it got to do with any global libraries such as an older version of oriento being used?

…ass` if it's null or empty to allow user's submitted classes

dmarcelino · 2015-07-10T11:41:29Z

Good to hear that!

When sails-orientdb retrieves records from OrientDB it gets that metadata. It attempts to clean it where possible though I don't think it's cleaning it for embedded records... It seems the data is being added but it's really just saving what was retrieved.

I've made an improvement to the workaround (10299b1), please test. Once you merge tommykennedy#1 I'll be able to merge this PR.

appscot#116: attempt to fix error on edge creation

Create Test_edge_creation

dmarcelino · 2015-07-10T11:56:34Z

Thanks @tommykennedy for the report and test!

tommykennedy · 2015-07-10T12:18:42Z

No problem happy to contribute and I learned a lot to contribute more in the future

Sent from my iPhone

On 10 Jul 2015, at 12:56, Dário [email protected] wrote:

Thanks @tommykennedy for the report and test!

—
Reply to this email directly or view it on GitHub.

tommykennedy added 3 commits July 7, 2015 19:08

Create Test_edge_creation

98d0b05

Test_Edge_Creation

760643a

Update Test_Edge_Creation

420a344

dmarcelino reviewed Jul 8, 2015
View reviewed changes

Update and rename Test_Edge_Creation to 116-test_edge_creation.js

bfb036b

Update 116-test_edge_creation.js

7fddffd

dmarcelino added 2 commits July 10, 2015 12:14

appscot#116: attempt to fix error on edge creation

cbe757a

appscot#116: deleted extraneous file

b58d6d8

appscot#116: improvements to create edge workaround, only delete `@cl…

10299b1

…ass` if it's null or empty to allow user's submitted classes

Merge pull request #1 from appscot/create_edge

080b13a

appscot#116: attempt to fix error on edge creation

dmarcelino added a commit that referenced this pull request Jul 10, 2015

Merge pull request #119 from tommykennedy/patch-1

f1dc1ca

Create Test_edge_creation

dmarcelino merged commit f1dc1ca into appscot:master Jul 10, 2015

dmarcelino mentioned this pull request Jul 10, 2015

Found class name null or empty #116

Closed

dmarcelino mentioned this pull request Jul 4, 2016

OrientDB.RequestError: Found class name null or empty #141

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Test_edge_creation #119

Create Test_edge_creation #119

tommykennedy commented Jul 7, 2015

dmarcelino Jul 8, 2015

dmarcelino commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

dmarcelino commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

dmarcelino commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

tommykennedy commented Jul 10, 2015

dmarcelino commented Jul 10, 2015

tommykennedy commented Jul 10, 2015

dmarcelino commented Jul 10, 2015

tommykennedy commented Jul 10, 2015

dmarcelino commented Jul 10, 2015

dmarcelino commented Jul 10, 2015

tommykennedy commented Jul 10, 2015


		var self = this;

		describe('Issue: Found class name null', function () {

Create Test_edge_creation #119

Create Test_edge_creation #119

Conversation

tommykennedy commented Jul 7, 2015

dmarcelino Jul 8, 2015

Choose a reason for hiding this comment

dmarcelino commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

dmarcelino commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

dmarcelino commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

tommykennedy commented Jul 8, 2015

tommykennedy commented Jul 10, 2015

dmarcelino commented Jul 10, 2015

tommykennedy commented Jul 10, 2015

dmarcelino commented Jul 10, 2015

tommykennedy commented Jul 10, 2015

dmarcelino commented Jul 10, 2015

dmarcelino commented Jul 10, 2015

tommykennedy commented Jul 10, 2015