Skip to content

Commit

Permalink
d Document work done on #6 - detecting QCOMPARE
Browse files Browse the repository at this point in the history
Co-Authored-By: Llewellyn Falco <[email protected]>
  • Loading branch information
claremacrae and isidore committed Sep 8, 2021
1 parent 285f918 commit d9910c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions build/relnotes_x.y.z.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* **New features**
* None
* **Bug fixes**
* Add compile-time checks to prevent incorrect use of `QCOMPARE` from the Catch2 framework (#6 - thanks to Fabial Kosmale of Qt)
* Now creates valid image files for new image-based approval tests (#7)
* **Other changes**
* None
1 change: 1 addition & 0 deletions mdsource/README.source.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ You can download the [Starter Project](https://github.com/approvals/ApprovalTest
## Limitations

* **IMPORTANT:** Do not use the [Qt Test macros](https://doc.qt.io/qt-5/qtest.html#macros), such as `QCOMPARE`, `QVERIFY`, `QTRY_COMPARE` and so on. **Currently, any test failures of all any of the Qt Test macros will be silently swallowed, and tests will spuriously pass.**
* Currently, there are compile-time checks to prevent incorrect use of `QCOMPARE`, but not the others.
* Please note that this is a very early implementation, and there is not yet any promise of a stable interface.

## Reference
Expand Down

0 comments on commit d9910c6

Please sign in to comment.