feat(worker): support graceful shutdown #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notifications workers and queue have are sent to APNs/FCM before a push notification service is shutdown. fixed: #441 Signed-off-by: Bo-Yi Wu <[email protected]>
golangcibot
reviewed
Feb 4, 2020
| ctx, cancel := context.WithCancel(ctx) | ||
| go func() { | ||
| c := make(chan os.Signal) | ||
| signal.Notify(c, syscall.SIGINT, syscall.SIGTERM) |
There was a problem hiding this comment.
SA1017: the channel used with signal.Notify should be buffered (from staticcheck)
Signed-off-by: Bo-Yi Wu <[email protected]>
Signed-off-by: Bo-Yi Wu <[email protected]>
send buffered channel to signal.Notify to avoid blocking golang/lint#175 Signed-off-by: Bo-Yi Wu <[email protected]>
golangcibot
reviewed
Feb 4, 2020
main.go
Outdated
| ctx, cancel := context.WithCancel(ctx) | ||
| go func() { | ||
| c := make(chan os.Signal, 1) | ||
| signal.Notify(c, syscall.SIGINT, syscall.SIGTERM, os.Interrupt, os.Kill) |
There was a problem hiding this comment.
SA1016: os.Kill cannot be trapped (did you mean syscall.SIGTERM?) (from staticcheck)
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 83.05% 82.99% -0.06%
==========================================
Files 20 20
Lines 1393 1394 +1
==========================================
Hits 1157 1157
- Misses 188 189 +1
Partials 48 48
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notifications workers and queue have are sent to APNs/FCM before a push notification service is shutdown.
fixed: #441
how to test
# build docker make build_linux_amd64 docker_imagecreate a new console:
create another console:
You will see the log in the first console:
Signed-off-by: Bo-Yi Wu [email protected]