Support HTTP proxy for APNs #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Dec 6, 2019
emiksk
force-pushed
the
support-proxy-for-apns
branch
from
307a205 to
0073e9f
Compare
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=========================================
+ Coverage 82.86% 83.07% +0.2%
=========================================
Files 20 20
Lines 1360 1394 +34
=========================================
+ Hits 1127 1158 +31
+ Misses 190 188 -2
- Partials 43 48 +5
Continue to review full report at Codecov.
|
appleboy
approved these changes
Dec 7, 2019
|
LGTM. This also supports |
|
@appleboy |
Agreed - Curious if there's a plan to have this released... any idea on timeline? Thanks in advance! |
|
+1 on the above questions regarding a release ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented this feature based on sideshow/apns2#158.
This will make a request to APNs go through a proxy server if you have configured http_proxy. That means this change is backward incompatible.
I don't think it's a serious problem because anyone who uses the http_proxy option must have a proxy server available.
What do you think about it?