Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemInternals: support mocking on Windows #9

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Collaborator

Add the Windows threading APIs for thread local storage. Prefer the FLS
allocations over TLS allocations simply because they give us more
similar semantics.

Add the Windows threading APIs for thread local storage.  Prefer the FLS
allocations over TLS allocations simply because they give us more
similar semantics.
@compnerd
Copy link
Collaborator Author

@milseman - let me know if you have an idea of structuring the change here better. I suppose that we can create aliases for ThreadLocalSet and ThreadLocalGet for the cases where the return value is ignored, but the return conditions are different, which makes it a bit trickier.

@compnerd compnerd mentioned this pull request Oct 22, 2020
@milseman
Copy link
Contributor

Alright, I'll try to do some refactoring. Thanks for this!

@milseman
Copy link
Contributor

#10

@milseman
Copy link
Contributor

In #11, I actually implement this (I believe). Would you be open to me merging that PR after I slap on @inline(__always), closing this PR, and you following up with more Windows support on top of that?

@milseman
Copy link
Contributor

I think this can be closed. Feel free to reopen if I'm mistaken

@milseman milseman closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants