remove internal ExpressibleBy(Integer|Array)Literal conformances #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The ExpressibleBy*Literal conformances require `@usableFromInline` inits which make it harder to make NIO compatible with library evolution because we can no longer just remove all `@inlinable`s and call it a day. Modifications: Remove the ExpressibleBy*Literal conformances for internal types. Result: NIO easy to convert into a library evolution mode.
Lukasa
approved these changes
Nov 20, 2019
Yasumoto
pushed a commit
to Yasumoto/swift-nio
that referenced
this pull request
Nov 21, 2019
…le#1258) Motivation: The ExpressibleBy*Literal conformances require `@usableFromInline` inits which make it harder to make NIO compatible with library evolution because we can no longer just remove all `@inlinable`s and call it a day. Modifications: Remove the ExpressibleBy*Literal conformances for internal types. Result: NIO easy to convert into a library evolution mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The ExpressibleBy*Literal conformances require
@usableFromInlineinitswhich make it harder to make NIO compatible with library evolution
because we can no longer just remove all
@inlinables and call it aday.
Modifications:
Remove the ExpressibleBy*Literal conformances for internal types.
Result:
NIO easy to convert into a library evolution mode.