Add a variant of configureAsyncHTTP2Pipeline which takes a stream delegate #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egate Motivation: `configureAsyncHTTP2Pipeline` doesn't allow a stream delegate to be specified. As the async pipeline uses the "inline" stream multiplexer there's no way to account for streams within the connection channel. Modifications: - Add a sync and async variants of `configureAsyncHTTP2Pipeline` which accepts an optional stream delegate - Rewrite the existing helpers in terms of the new one Result: Users can configure an async http pipeline with a stream delegate.
Lukasa
requested changes
May 3, 2024
Lukasa
approved these changes
May 16, 2024
glbrntt
pushed a commit
that referenced
this pull request
Nov 14, 2024
…eam delegate (#471) In the async HTTP2 pipeline there is no way to account for the opening and closing of streams. This PR adds a variant of `configureAsyncHTTPServerPipeline` (HTTP2 upgrade channel) that allows the user to pass in a `NIOHTTP2StreamDelegate` to be applied to the HTTP2 channel if the upgrade occurs. This is similar to #439 which did the same HTTP2 only channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
configureAsyncHTTP2Pipelinedoesn't allow a stream delegate to be specified. As the async pipeline uses the "inline" stream multiplexer there's no way to account for streams within the connection channel.Modifications:
configureAsyncHTTP2Pipelinewhich accepts an optional stream delegateResult:
Users can configure an async http pipeline with a stream delegate.