Skip to content

Commit

Permalink
Line based unacceptable language overrides.
Browse files Browse the repository at this point in the history
  • Loading branch information
PeterAdams-A committed Oct 23, 2024
1 parent 4b18978 commit a01a4d9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
2 changes: 0 additions & 2 deletions .unacceptablelanguageignore
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
IntegrationTests/run-tests.sh
Tests/hpack-test-case/*/story_20.json
scripts/test_h2spec.sh
4 changes: 2 additions & 2 deletions IntegrationTests/run-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ fi

# report
if [[ $cnt_fail > 0 ]]; then
# kill leftovers (the whole process group)
# kill leftovers (the whole process group) # ignore-unacceptable-language
trap '' TERM
kill 0
kill 0 # ignore-unacceptable-language

plugins_do summary_fail "$cnt_ok" "$cnt_fail"
else
Expand Down
8 changes: 4 additions & 4 deletions scripts/test_h2spec.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ function server_lsof() {

function stop_server() {
sleep 0.5 # just to make sure all the fds could be closed
kill -0 "$1" # assert server is still running
kill "$1" # tell server to shut down gracefully
kill -0 "$1" # assert server is still running # ignore-unacceptable-language
kill "$1" # tell server to shut down gracefully # ignore-unacceptable-language
for f in $(seq 20); do
if ! kill -0 "$1" 2> /dev/null; then
if ! kill -0 "$1" 2> /dev/null; then # ignore-unacceptable-language
break # good, dead
fi
ps auxw | grep "$1" || true
sleep 0.1
done
if kill -0 "$1" 2> /dev/null; then
if kill -0 "$1" 2> /dev/null; then # ignore-unacceptable-language
fail "server $1 still running"
fi
}
Expand Down

0 comments on commit a01a4d9

Please sign in to comment.