Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ESP-IDF tooling to master (or v5.4 when released) to fix Embedded Swift Crashes #25

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

PaulSolt
Copy link
Contributor

@PaulSolt PaulSolt commented Oct 7, 2024

Fixes Embedded Swift issues. Random numbers do not work on 5.1.2 - 5.3.1 in addition to several issues.

Note: The fix is on master, but we don't have a 5.4 release yet. Since Embedded Swift is experimental, it makes sense to be recommending tooling that solves current problems. There is some risk in not having a stable ESP-IDF release.

Please stay in the master (v5.4) branch. Don't checkout to the release v5.2 or v5.3
As a summary;
We have fixed the The gap between ... errors in this repo with the 2eb2975 . No change in the IDF releases.
We don't have getentropy error in IDF master (v5.4) branch. No need to apply a patch.
For the previous idf releases (v5.3.x and v5.2.x), apply the patch I prepared. https://github.com/user-attachments/files/15877608/0001-newlib-getentropy-implementation.patch

apple/swift-embedded-examples#17 (comment)

…ues for Embedded Swift. Random numbers do not work on 5.1.2 - 5.3.1, the fix is on master, but we don't have a 5.4 release yet. There are other fixes as well.
@rauhul
Copy link
Collaborator

rauhul commented Oct 8, 2024

I'd like to hold off on this until 5.4 is released

@rauhul
Copy link
Collaborator

rauhul commented Oct 14, 2024

@erhankur do we have a rough idea of when 5.4.0 will be released?

@erhankur
Copy link

@rauhul We plan to make the final release in February next year.

@rauhul
Copy link
Collaborator

rauhul commented Oct 14, 2024

Oh ok thats a while away, we can use the master branch until then.

@rauhul rauhul merged commit b4d5d41 into apple:main Oct 14, 2024
@PaulSolt
Copy link
Contributor Author

@rauhul @erhankur Thanks! I think this is a good starting point for Embedded Swift until 5.4 is released. We should pin it to 5.4 when it's available as it solves some pain points and crashes.

@PaulSolt PaulSolt deleted the psolt/esp-idf-version branch October 14, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants