Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HTTPRequest.url to the main library #79

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

guoye-zhang
Copy link
Contributor

Resolves #76

@guoye-zhang
Copy link
Contributor Author

Are there ways to re-export these symbols so we don't need to introduce API breakages?

2 breaking changes detected in HTTPTypesFoundation:
  💔 API breakage: var HTTPRequest.url has been removed
  💔 API breakage: constructor HTTPRequest.init(method:url:headerFields:) has been removed

Maybe @_exported import or @_disfavoredOverload?

@Lukasa
Copy link

Lukasa commented Dec 16, 2024

@_exported import is totally workable.

@guoye-zhang
Copy link
Contributor Author

@_exported import doesn't seem to address the API breakage check. Maybe the check itself is too strict?

@Lukasa
Copy link

Lukasa commented Dec 19, 2024

API breakage is usually strict, and I think this is one way in which it is.

@FranzBusch FranzBusch added the 🔨 semver/patch No public API change. label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import HTTPTypesFoundation pulls in FoundationNetworking
3 participants