New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug tests #21

Merged

fboemer merged 1 commit into main from fboemer/fix-debug-tests

Jul 19, 2024

Contributor

fboemer commented Jul 19, 2024

The culprits:

subtractIfExceeds had an incorrect assert
forwardNtt had
- incorrect initialization of maxLazyReductionCounter, as well as
- incorrect update of lazyReductionCounter for a special case when modulus.ceilLog2 == T.bitWidth - 3


          Fix debug tests

a972014

fboemer requested review from karulont and RuiyuZhu as code owners

July 19, 2024 16:52

fboemer enabled auto-merge (squash)

July 19, 2024 17:04

karulont approved these changes

View reviewed changes

fboemer merged commit 8a67b7b into main

fboemer deleted the fboemer/fix-debug-tests branch

July 19, 2024 17:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet