Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More readable logs for PIRProcessDatabase duplicate keywords #125

Merged
merged 1 commit into from
Oct 29, 2024
Merged

More readable logs for PIRProcessDatabase duplicate keywords #125

merged 1 commit into from
Oct 29, 2024

Conversation

fboemer
Copy link
Contributor

@fboemer fboemer commented Oct 29, 2024

When PIRProcessDatabase encounters duplicate keywords, the error logs aren't very readable:
Before:

Error: Invalid database: Duplicate values [97, 115, 99, 105, 105, 33], [160, 171, 131, 226, 93, 84, 175, 141, 70, 218] for keyword [51]

After:

Error: Invalid database: Duplicate values 'ascii! (utf8)', 'oKuD4l1Ur41G2g== (base64)' for keyword '3 (utf8)'

@fboemer fboemer marked this pull request as ready for review October 29, 2024 16:16
@fboemer fboemer force-pushed the fboemer/better-logging-duplicate-keywords branch from cb23c59 to 634b0ff Compare October 29, 2024 16:21
@fboemer fboemer merged commit 9df2a88 into main Oct 29, 2024
5 checks passed
@fboemer fboemer deleted the fboemer/better-logging-duplicate-keywords branch October 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karulont karulont karulont approved these changes

@RuiyuZhu RuiyuZhu Awaiting requested review from RuiyuZhu RuiyuZhu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fboemer @karulont