Fix more Sendable warnings and flaky test
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phausler
reviewed
Jul 27, 2023
| dependencies: ["_CAsyncSequenceValidationSupport", "AsyncAlgorithms"]), | ||
| dependencies: ["_CAsyncSequenceValidationSupport", "AsyncAlgorithms"], | ||
| swiftSettings: [ | ||
| .enableExperimentalFeature("StrictConcurrency=complete"), |
| @@ -0,0 +1,51 @@ | |||
| // swift-tools-version: 5.6 | |||
There was a problem hiding this comment.
This can be 5.6 since we don’t use any 5.7 toolchain feature in here. The name of the file is the important part.
[email protected]
Outdated
| @@ -0,0 +1,51 @@ | |||
| // swift-tools-version: 5.6 | |||
There was a problem hiding this comment.
The @swift-5.6 suffix is canonical?
There was a problem hiding this comment.
What do you mean with canonical? SPM used these suffixes to identify what manifest to pick for a given swift version
There was a problem hiding this comment.
ah, yea I did not realize that swiftpm uses those suffixes, seems reasonable then
# Motivation We still had some `Sendable` warnings left under strict Concurrency checking. # Modification This PR fixes a bunch of `Sendable` warnings but we still have some left in the validation tests. Additionally, I fixed a flaky test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We still had some
Sendablewarnings left under strict Concurrency checking.Modification
This PR fixes a bunch of
Sendablewarnings but we still have some left in the validation tests. Additionally, I fixed a flaky test.