-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebAssembly support #273
Conversation
Neat! Is this ready to merge? |
Thanks for the review @phausler! |
yup, got ya on that. Was just making sure that it included everything for that support |
I don't think this was actually building or testing a WebAssembly binary. To produce one you have to pass Additionally you would have to add |
Oh, I used the Did I miss anything? Thank you |
I think @0xpablo's build log attached in the PR description shows a build for x86_64-unknown-linux, but this PR changes certainly fix the build for wasm32-unknown-wasi. # First, rollback to 5.8 compatible revision because the latest main uses ExecutorJob since 156bb4bf495789bf1f13b78cfa741d193a2f4700
$ git checkout 936a68d01218f5ddeaacbef63fdb45af6c20c360
# Cherry-pick this PR changes
$ git cherry-pick adb12bfcccaa040778c905c5a50da9d9367fd0db
$ swift build --triple wasm32-unknown-wasi # OK But |
Hi everyone,
This PR adds support for WebAssembly (and possibly other single threaded environments).
I made the primitive an Int instead of a Void to avoid the
UnsafeMutablePointer<Void> has been replaced by UnsafeMutableRawPointer
warning.Build and tests running on SwiftWasm on Linux
Thanks in advance!