Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Kagi Orion web browser #869

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

zcutlip
Copy link
Contributor

@zcutlip zcutlip commented Feb 10, 2025

add Kagi Orion web browser to web-browser-extension-distribution-information.json

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

for change-password-URLs.json

  • There is no Well-Known URL for Changing Passwords (https://example.com/.well-known/change-password)
  • The URL either makes the experience better or no worse than being directed to just the domain in a non-logged-in state

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)
  • If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

for shared-credentials-historical.json

  • You believe that the domains were associated at some point in the past and can explain that relationship

@@ -352,6 +352,25 @@
"supported_store_identifiers": [
5
]
},
{
"long_name": "Orion",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the long name should be “Orion Browser by Kagi”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Wasn't sure if this was a formal thing found in the application bundle or a convenience thing for this project. I'll update

@rmondello rmondello merged commit 3428ad4 into apple:main Feb 11, 2025
5 checks passed
@zcutlip zcutlip deleted the add-orion-web-browser branch February 11, 2025 04:07
rmondello pushed a commit to rmondello/password-manager-resources that referenced this pull request Feb 11, 2025
* add Kagi Orion web browser to web-browser-extension-distribution-information.json

* update long_name for Orion browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants