Minimal Update to JWTKit 5 #68
Open
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tim Condon <[email protected]> Co-Authored-By: Paul Toffoloni <[email protected]>
|
If the main concern is changing the major version dependency from 4 to 5, vapor/jwt-kit#221 will help add additional support that this library in particular can use to remain backwards compatible with version 4 while also supporting 5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #14, here is the minimal set of changes to move this over to JWTKit 5. As this library is likely blocking adoption for many upstream projects, I'm hoping this can accelerate the process before more full-fledged support can be added from #14.