Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing a configuration error in the constructor if appAppleId is null/nil/undefined and the environment is Production #35

Merged

Conversation

shimastripe
Copy link
Contributor

WHAT

  • Throw configuration error if appAppleId is nil and the environment is Production.
  • Add a comment stating that it is required for Production.

README.md Outdated
@@ -57,11 +57,12 @@ import AppStoreServerLibrary

let bundleId = "com.example"
let appleRootCAs = loadRootCAs() // Specific implementation may vary
let appAppleId: String? = nil // For production environments, it's required
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an Int64?, also could you please use the phrase "appAppleId must be provided for the Production environment"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry! I fixed it. b2a7bc4

Copy link
Collaborator

@alexanderjordanbaker alexanderjordanbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR and issue

@alexanderjordanbaker alexanderjordanbaker merged commit 6aa69ae into apple:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants