Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: jsrsasign package audit issue #62

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Fix: jsrsasign package audit issue #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c2edb1
fix jsrsasign audit issue
betimer Jan 22, 2024
a20217a
update user agent
betimer Jan 25, 2024
fac7ffc
Merge branch 'main' into fix/npm-audit-jsrsasign-issue
alexanderjordanbaker Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ import { URLSearchParams } from 'url';
export class AppStoreServerAPIClient {
private static PRODUCTION_URL = "https://api.storekit.itunes.apple.com";
private static SANDBOX_URL = "https://api.storekit-sandbox.itunes.apple.com";
private static USER_AGENT = "app-store-server-library/node/1.0.0";
private static USER_AGENT = "app-store-server-library/node/1.0.1";

private issuerId: string
private keyId: string
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@apple/app-store-server-library",
"version": "1.0.0",
"version": "1.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to bump the version, please also bump the version in the user agent string as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderjordanbaker good spot. done.

"description": "The App Store Server Library",
"main": "dist/index.js",
"keywords": [],
Expand All @@ -12,12 +12,12 @@
"types": "dist/index.d.ts",
"dependencies": {
"@types/jsonwebtoken": "^9.0.5",
"@types/jsrsasign": "^10.5.8",
"@types/jsrsasign": "^10.5.12",
"@types/node": "^20.11.5",
"@types/node-fetch": "^2.6.3",
"base64url": "^3.0.1",
"jsonwebtoken": "^9.0.2",
"jsrsasign": "^10.9.0",
"jsrsasign": "^11.0.0",
"node-fetch": "^2.7.0"
},
"devDependencies": {
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,10 +753,10 @@
dependencies:
"@types/node" "*"

"@types/jsrsasign@^10.5.8":
version "10.5.8"
resolved "https://registry.yarnpkg.com/@types/jsrsasign/-/jsrsasign-10.5.8.tgz#0d6c638505454b5e95c684d6f604d57641417336"
integrity sha512-1oZ3TbarAhKtKUpyrCIqXpbx3ZAfoSulleJs6/UzzyYty0ut+kjRX7zHLAaHwVIuw8CBjIymwW4J2LK944HoHQ==
"@types/jsrsasign@^10.5.12":
version "10.5.12"
resolved "https://registry.yarnpkg.com/@types/jsrsasign/-/jsrsasign-10.5.12.tgz#39ca12e576249f1a5494943d1c0c49c9087bf13d"
integrity sha512-sOA+eVnHU+FziThpMhuqs/tjFKe5gHVJKIS7g1BzhXP+e2FS8OvtzM0K3IzFxVksDOr98Gz5FJiZVxZ9uFoHhw==

"@types/node-fetch@^2.6.3":
version "2.6.4"
Expand Down Expand Up @@ -1922,10 +1922,10 @@ jsonwebtoken@^9.0.2:
ms "^2.1.1"
semver "^7.5.4"

jsrsasign@^10.9.0:
version "10.9.0"
resolved "https://registry.yarnpkg.com/jsrsasign/-/jsrsasign-10.9.0.tgz#cc3f316e7e4c112a976193f9d2c93deb5a0745ee"
integrity sha512-QWLUikj1SBJGuyGK8tjKSx3K7Y69KYJnrs/pQ1KZ6wvZIkHkWjZ1PJDpuvc1/28c1uP0KW9qn1eI1LzHQqDOwQ==
jsrsasign@^11.0.0:
version "11.0.0"
resolved "https://registry.yarnpkg.com/jsrsasign/-/jsrsasign-11.0.0.tgz#766570c21f87d68075a142f5188f7e583cee9d70"
integrity sha512-BtRwVKS+5dsgPpAtzJcpo5OoWjSs1/zllSBG0+8o8/aV0Ki76m6iZwHnwnsqoTdhfFZDN1XIdcaZr5ZkP+H2gg==

jwa@^1.4.1:
version "1.4.1"
Expand Down