Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linkText and partialLinkText search locators to @SelendroidFindBy annotation #145

Merged
merged 3 commits into from
Jan 5, 2015

Conversation

clicman
Copy link
Contributor

@clicman clicman commented Dec 30, 2014

Since @SelendroidFindBy(name="...") actually serches by accessibility id (according to selendroid documentation), I`ve added support for linkText and partialLinkText search strategies which searches by displayed element text.

@TikhomirovSergey
Copy link
Contributor

Good! :) But...
@clicman please improve test here: https://github.com/clicman/java-client/commit/0c2f13d3346d0dd647518fa0c0e11e2b3dfbba40#diff-19d657f49e403606a5f2ecf5f42a4bafR72
Partial text should be here :)

Also. It is a little wish. What do think about the remaming of linktext and partiallinktext to text and partialtext? :)

@SelendroidFindBy(text = "Accessibility")

and

@SelendroidFindBy(partialtext = "cessibilit")

As all this work has been done for native contents so I think this strategy names are more meaningful.

@clicman
Copy link
Contributor Author

clicman commented Dec 31, 2014

Also. It is a little wish. What do think about the remaming of linktext and partiallinktext to text and partialtext? :)

My opinion is keep it like it named in webdriver methods to conform naming across the api. More variation - more confusion.

@TikhomirovSergey
Copy link
Contributor

ok!

Jonahss added a commit that referenced this pull request Jan 5, 2015
Add support for linkText and partialLinkText search locators to @SelendroidFindBy annotation
@Jonahss Jonahss merged commit f05897d into appium:master Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants