Add reduce motion #760
Add reduce motion #760
Conversation
lib/driver.js
Outdated
| @@ -337,6 +337,11 @@ class XCUITestDriver extends BaseDriver { | |||
| await shutdownOtherSimulators(this.opts.device); | |||
| } | |||
|
|
|||
| // set reduceMotion if desired | |||
| if (this.opts.reduceMotion) { | |||
There was a problem hiding this comment.
if util.hasValue(...)
|
can you append the capability in README? |
| if (!process.env.REAL_DEVICE) { | ||
| it('should enable reduce motion', async function () { | ||
| driver = await initSession(caps); | ||
| let el = await driver.elementsByXPath('//XCUIElementTypeCell[@name="General"]'); |
There was a problem hiding this comment.
xpath locators are slow. Please use either accessibility id or predicate locators instead
There was a problem hiding this comment.
for example:
accessiblityId: General
predicate: type == 'XCUIElementTypeCell' AND name == 'General'
There was a problem hiding this comment.
reading docs since I never used accessiblityId.
| it('should enable reduce motion', async function () { | ||
| driver = await initSession(caps); | ||
| let el = await driver.elementsByXPath('//XCUIElementTypeCell[@name="General"]'); | ||
| await el[0].click(); |
There was a problem hiding this comment.
why you are looking for elements if you only need a single one?
There was a problem hiding this comment.
my bad. Changing that.
| if (!process.env.REAL_DEVICE) { | ||
| it('should enable reduce motion', async function () { | ||
| driver = await initSession(caps); | ||
| let el = await driver.element('-ios predicate string', "type == 'XCUIElementTypeCell' AND name == 'General'"); |
There was a problem hiding this comment.
'-ios predicate string' can be a constant
| const udid = await createDevice(SIM_DEVICE_NAME, | ||
| SETTINGS_CAPS.deviceName, SETTINGS_CAPS.platformVersion); | ||
| baseCaps = Object.assign({}, SETTINGS_CAPS, {udid}); | ||
| caps = Object.assign({usePrebuiltWDA: true, "reduceMotion": true}, baseCaps); |
There was a problem hiding this comment.
quotes are redundant
|
Do these tests work locally for you? Turning off doesn't seem to work. |
* add new capability for setting reduceMotion on simulators * call reduceMotion * use util.hasValue * add functional test for reduceMotion * update appium-ios-simulator version * add capabilities for settings app * update comment desc * add line break * update readme, add reduceMotion capabiilty * update functional tests * update readme, add reduceMotion capabiilty * update readme, add reduceMotion capabiilty * update functional tests * fix test
[Work in progress]
Add reduceMotion for simulators