chore: skip connected device check if the caps had webDriverAgentUrl #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
commented
Mar 23, 2024
lib/driver.js
Outdated
| throw new Error(`Unknown device or simulator UDID: '${this.opts.udid}'`); | ||
| // If the session specified this.opts.webDriverAgentUrl with a real device, | ||
| // we can assume the user prepared the device properly already. | ||
| if (this.isRealDevice() && this.opts.webDriverAgentUrl) { |
There was a problem hiding this comment.
Possibly this real device check is not necessary
lib/driver.js
Outdated
| // If the session specified this.opts.webDriverAgentUrl with a real device, | ||
| // we can assume the user prepared the device properly already. | ||
| if (this.opts.webDriverAgentUrl) { | ||
| this.logs.debug('Skip checking the device availability since the session specifies appium:webDriverAgentUrl'); |
There was a problem hiding this comment.
Skipping checking of
mykola-mokhnach
approved these changes
Mar 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 24, 2024
## [7.5.1](v7.5.0...v7.5.1) (2024-03-24) ### Miscellaneous Chores * skip connected device check if the caps had webDriverAgentUrl ([#2351](#2351)) ([407ad58](407ad58))
|
🎉 This PR is included in version 7.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
KazuCocoa
added a commit
that referenced
this pull request
Mar 25, 2024
…2351) * chore: skip connected device check if the caps had webDriverAgentUrl * fix lint * Update driver.js * Update driver.js
KazuCocoa
pushed a commit
that referenced
this pull request
Mar 25, 2024
## [7.5.1](v7.5.0...v7.5.1) (2024-03-24) ### Miscellaneous Chores * skip connected device check if the caps had webDriverAgentUrl ([#2351](#2351)) ([407ad58](407ad58))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered if we simply can skip the connected devices check with
webDriverAgentUrlsincewebDriverAgentUrlusually means the caller prepared the device properly for the session