fix: parsing SSL output from OpenSSL output #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
changed the title
ghost
marked this pull request as ready for review
mykola-mokhnach
approved these changes
Nov 27, 2020
|
@mykola-mokhnach I've removed the redundant imports. Please merge. |
|
Unfortunately I cannot merge without the license signed :( |
|
@mykola-mokhnach done |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2020
## [3.32.2](v3.32.1...v3.32.2) (2020-11-28) ### Bug Fixes * parsing output from OpenSSL ([#1256](#1256)) ([49fb7ed](49fb7ed))
|
🎉 This PR is included in version 3.32.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
triager
pushed a commit
that referenced
this pull request
Nov 30, 2020
Merged
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
## [3.32.2](appium/appium-xcuitest-driver@v3.32.1...v3.32.2) (2020-11-28) ### Bug Fixes * parsing output from OpenSSL ([appium#1256](appium#1256)) ([49fb7ed](appium@49fb7ed))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The separator (
/) for the values of the output in LibreSSL (OpenSSL in MacOS/OpenBSD) is different from the separator,in OpenSSL in Linux.appium-xcuitest-driver is expecting to run on macOS so the regex which parses the output from LibreSSL (OpenSSL in MacOS/OpenBSD) doesn't work when using OpenSSL.
This patch adds the fallback to parse the OpenSSL output in case it fails to parse the LibreSSL output.