fix: properly handle promise during wait for atom #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -302,6 +311,7 @@ extensions.waitForAtom = async function waitForAtom (promise) { | |||
| // check if there is an alert | |||
| if (await this.checkForAlert()) { | |||
There was a problem hiding this comment.
I'm not quite sure how this is going to work together with auto alert accept setting
mykola-mokhnach
approved these changes
Mar 27, 2020
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* fix: properly handle promise during wait for atom * fix: cancel atom promise when alert is found * try: fix some and try ard * fix: back to published ard * remove some unnecessary cap
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for proper promise, and make it cancellable so we don't get odd reports in the logs.
Also, remove some
killAllSimulatorcalls to speed some things up.