Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce simulatorPasteboardAutomaticSync as pasteboardAutomaticSync to handle pasteboard sync for simulator #1168

Merged
merged 3 commits into from
Feb 14, 2020
Merged

feat: introduce simulatorPasteboardAutomaticSync as pasteboardAutomaticSync to handle pasteboard sync for simulator #1168

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9defd6b
feat: introduce simulatorPasteboardAutomaticSync as pasteboardAutomat…
KazuCocoa Feb 13, 2020
7952510
address case insensitive
KazuCocoa Feb 13, 2020
942e07d
make On and System to on and system [skip ci]
KazuCocoa Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Differences are noted here:
|`reduceMotion`| It allows to turn on/off reduce motion accessibility preference. Setting reduceMotion `on` helps to reduce flakiness during tests. Only on simulators | e.g `true` |
|`permissions`| Allows to set permissions for the specified application bundle on Simulator only. The capability value is expected to be a valid JSON string with `{"<bundleId1>": {"<serviceName1>": "<serviceStatus1>", ...}, ...}` format. Since Xcode SDK 11.4 Apple provides native APIs to interact with application settings. Check the output of `xcrun simctl privacy booted` command to get the list of available permission names. Use `yes`, `no` and `unset` as values in order to `grant`, `revoke` or `reset` the corresponding permission. Below Xcode SDK 11.4 it is required that `applesimutils` package is installed and available in PATH. The list of available service names and statuses can be found at https://github.com/wix/AppleSimulatorUtils. | e. g. `{"com.apple.mobilecal": {"calendar": "YES"}}` |
|`iosSimulatorLogsPredicate`|Set the `--predicate` flag in the ios simulator logs|e.g.: `'process != "locationd" AND process != "DTServiceHub"' AND process != "mobileassetd"`|

|`simulatorPasteboardAutomaticSync`| Handle the `-PasteboardAutomaticSync` flag when simulator process launches. It could improve launching simulator performance not to sync pasteboard with the system when this value is `off`. `On` forces the flag enabled. `System` does not provide the flag to the launching command. `on`, `off`, or `system` is available. They are case insensitive. Defaults to `off` | e.g. `system` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On and System still start with the uppercase letter


### General capabilities:

Expand Down
3 changes: 3 additions & 0 deletions lib/desired-caps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ let desiredCapConstraints = _.defaults({
connectHardwareKeyboard: {
isBoolean: true
},
simulatorPasteboardAutomaticSync: {
isString: true
},
calendarAccessAuthorized: {
isBoolean: true
},
Expand Down
1 change: 1 addition & 0 deletions lib/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,7 @@ class XCUITestDriver extends BaseDriver {
const runOpts = {
scaleFactor: this.opts.scaleFactor,
connectHardwareKeyboard: !!this.opts.connectHardwareKeyboard,
pasteboardAutomaticSync: this.opts.simulatorPasteboardAutomaticSync || 'off',
isHeadless: !!this.opts.isHeadless,
devicePreferences: {},
};
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"appium-idb": "^0",
"appium-ios-device": "^1.4.1",
"appium-ios-driver": "^4.0.0",
"appium-ios-simulator": "^3.18.0",
"appium-ios-simulator": "^3.19.0",
"appium-remote-debugger": "^8.2.0",
"appium-support": "^2.39.0",
"appium-webdriveragent": "^2.7.0",
Expand Down