Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add includeSafariInWebviews cap #1060

Merged
merged 1 commit into from
Sep 4, 2019
Merged

feat: add includeSafariInWebviews cap #1060

merged 1 commit into from
Sep 4, 2019

Conversation

imurchie
Copy link
Contributor

@imurchie imurchie commented Sep 3, 2019

Add a cap includeSafariInWebviews which signals to the remote debugger to add safari apps to the available list.

I would go for making this default to true but that would be a breaking change.

jlipps
jlipps approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess it's a breaking change only if people do bad things like rely on the length of the context list or the specific names that are returned. but we tell people those aren't guaranteed, don't we?

@imurchie
Copy link
Contributor Author

imurchie commented Sep 3, 2019

Yes. But I think it should remain as it was. If this proves to be useful for many people, we could co wider switching it in 2.0

@jlipps
Copy link
Member

jlipps commented Sep 3, 2019

👍

KazuCocoa
KazuCocoa approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@imurchie imurchie merged commit 49aa329 into master Sep 4, 2019
@imurchie imurchie deleted the isaac-safari-webviews branch September 11, 2019 16:21
khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this pull request May 10, 2021
@imurchie
feat: add includeSafariInWebviews cap (appium#1060)
3727216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps approved these changes

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imurchie @jlipps @KazuCocoa