Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not add fake root for searches with context #363

Merged
merged 8 commits into from
Jul 5, 2020

Conversation

mykola-mokhnach
Copy link
Contributor

When page source is built for the whole elements hierarchy that a fake hierarchy root is added, which contains some additional info about the display. It is also used as a holder for toast elements. Although, it makes no sense to add the same stuff to context searches where the xml root is some subelement.

appium/appium#14509

@dpgraham
Copy link
Contributor

dpgraham commented Jul 4, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/src/main/java/io/appium/uiautomator2/model/UiElementSnapshot.java  8
         

See the complete overview on Codacy

@mykola-mokhnach
Copy link
Contributor Author

@sshock I assume this change could also improve the perf of your tests if you use nested lookups

@sshock
Copy link
Contributor

sshock commented Jul 4, 2020

@mykola-mokhnach I don't think we are using any nested lookups, but happy to see more performance improvements and thanks for tagging me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants