Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix and enable some commands e2e specs #576

Merged
merged 14 commits into from
Jan 27, 2023
Merged

ci: fix and enable some commands e2e specs #576

merged 14 commits into from
Jan 27, 2023

Conversation

rerorero
Copy link
Contributor

@rerorero rerorero commented Jan 20, 2023 •
edited
Loading

I just started looking into appium/appium#16402
This PR aims for spec files directly under test/functional/commands dir. Subdirectories are not included.
I confirmed npm run e2e-test:commands passed on my laptop with android-30;google_apis;arm64-v8a emulator.

I have a question, what is process.env.TESTOBJECT_E2E_TESTS for? Do you still use it?

@rerorero rerorero marked this pull request as ready for review January 20, 2023 14:10
@KazuCocoa
Copy link
Member

process.env.TESTOBJECT_E2E_TESTS

It is maybe a legacy parameter recently we no longer use. TestObject is a service SauceLabs acquired long before.

@rerorero
Copy link
Contributor Author

rerorero commented Jan 23, 2023 •
edited
Loading

Got it, thank you for checking. Then I'll clean up them as well.

rerorero
rerorero commented Jan 23, 2023
View reviewed changes
.github/workflows/functional-test.yml
script: npm run e2e-test:driver
script: |
npm run e2e-test:driver
npm run e2e-test:commands
Copy link
Contributor Author

@rerorero rerorero Jan 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to have it run in a different step but resulted in a connection error to Appium server 🤔
Please let me know if you have better approaches to run multiple tests.

@rerorero
Copy link
Contributor Author

@KazuCocoa Do you mind triggering the CI?

@KazuCocoa
Copy link
Member

I've updated the actions' permission to require only a new github user. The next push won't require an approval

@rerorero
Copy link
Contributor Author

That's very helpful thank you!!

@rerorero
Copy link
Contributor Author

hum.. some tests seem to be flaky. Can you try Re-run failed jobs?

KazuCocoa
KazuCocoa approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
It's sufficient to pass a few devices. Others could be slow emulators etc. I'll merge after checking the test results

@KazuCocoa
Copy link
Member

Hm, errors are rotation and attributes things. They might be related to emulator versions etc.
We can merge this right now since at least two versions have passed completely. Better than before

@KazuCocoa KazuCocoa merged commit 5b89dde into appium:master Jan 27, 2023
@KazuCocoa
Copy link
Member

Thank you!

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

🎉 This PR is included in version 2.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arealmaas arealmaas mentioned this pull request Dec 4, 2023
Open
@arealmaas arealmaas mentioned this pull request Dec 18, 2023
Open
@arealmaas arealmaas mentioned this pull request Jan 8, 2024
Open
@arealmaas arealmaas mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rerorero @KazuCocoa