Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 support element that has newline replace to \n (#1440) #1442

Merged
merged 10 commits into from
Apr 30, 2024
Merged

fix: 🐛 support element that has newline replace to \n (#1440) #1442

merged 10 commits into from
Apr 30, 2024

Conversation

miwtoo
Copy link
Contributor

@miwtoo miwtoo commented Apr 29, 2024 •
edited
Loading

I created a pull request for feature request #1440. I would appreciate if you could please review it and provide any suggestions.

Change
Screenshot 2567-04-30 at 00 31 52

Before
image

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the enhancement New feature or request label Apr 29, 2024
@miwtoo miwtoo mentioned this pull request Apr 29, 2024
Closed
eglitise
eglitise requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@eglitise eglitise left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR!
While the code seems reasonable to me, this does not fix how the text is displayed in the application source tree. I think a proper fix might require changes in the xmlToJSON method instead.
(edit: I would also call this a fix rather than a feature, since the XML is correct, but the Inspector GUI is not)

@miwtoo miwtoo changed the title feat: ✨ support element that has newline replace to \n (#1440) fix: 🐛 support element that has newline replace to \n (#1440) Apr 29, 2024
@github-actions github-actions bot added the fix This resolves a user-facing problem label Apr 29, 2024
@miwtoo
Copy link
Contributor Author

miwtoo commented Apr 29, 2024 •
edited
Loading

Thanks for the quick PR! While the code seems reasonable to me, this does not fix how the text is displayed in the application source tree. I think a proper fix might require changes in the xmlToJSON method instead. (edit: I would also call this a fix rather than a feature, since the XML is correct, but the Inspector GUI is not)

@eglitise I was changed in xmlToJSON Could you review it again?
Screenshort:
Screenshot 2567-04-30 at 04 02 14

@eglitise eglitise removed the enhancement New feature or request label Apr 29, 2024
eglitise
eglitise approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@eglitise eglitise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eglitise eglitise merged commit 60593f7 into appium:main Apr 30, 2024
6 checks passed
@jlipps
Copy link
Member

jlipps commented May 1, 2024

thanks @miwtoo !

laib3 pushed a commit to laib3/appium-inspector that referenced this pull request Nov 16, 2024
@miwtoo
fix: 🐛 support element that has newline replace to \n (appium#1442)
233e67a 
* feat: ✨ support element that has newline replace to \n (appium#1440)

* style: 🚨 fix style (appium#1440)

* refactor: ♻️ move Regex part to more reuseable

* fix: 🐛 Inspector GUI is not newline not show correctly

* fix: 🔥 getback comment

* fix: 🚨 fix lint

* fix: 💬 no extra spacing

* fix: 🗑️ remove unuse regex character

* refactor: ♻️ clean unuse attributes in test

* refactor: ♻️ remove more unuse in test hierarchy attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eglitise eglitise eglitise approved these changes

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@mykola-mokhnach mykola-mokhnach Awaiting requested review from mykola-mokhnach

Assignees
No one assigned
Labels
fix This resolves a user-facing problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miwtoo @jlipps @KazuCocoa @eglitise