fix: correctly account for position and scroll values of webviews #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
force-pushed
the
jlipps/webview-offset
branch
from
d129737
to
d527402
Compare
KazuCocoa
approved these changes
Mar 5, 2024
eglitise
reviewed
Mar 5, 2024
jlipps
force-pushed
the
jlipps/webview-offset
branch
from
d527402
to
4aa5e08
Compare
eglitise
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
window.scrollXandwindow.scrollYwere also not considered, which are necessary when thinking about the positions of web elements on the screen (web element position is absolute, not viewport relative as mobile elements are).