Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev install doc and single test run #1223

Merged
merged 5 commits into from
Nov 26, 2023

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Nov 26, 2023

  1. Better use npm ci than npm install, to fully rely on package-lock.json and not possibly modify it unintentionally

  2. Add note about node-gyp required installs for python and c/c++ compiler tools

  3. Running webview-helpers-specs.js only in my IDE resulted in

TypeError: Cannot read properties of undefined (reading 'eql')

And I found that it is the only spec that calls chai.use(chaiAsPromised); but not chai.should();.

Copy link

linux-foundation-easycla bot commented Nov 26, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Collaborator

@eglitise eglitise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eglitise eglitise merged commit 6b64cd6 into appium:main Nov 26, 2023
5 checks passed
@ath0mas ath0mas deleted the fix/dev-install-test branch November 26, 2023 20:36
shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
* docs: correct npm run e2e

* docs: better use npm ci than install

to fully rely on package-lock.json and not possibly modify it unintentionally

* docs: dev uses node-gyp and requires python and c/c++ compiler tools

* fix(test): missing chai.should init, to run given spec only in the ide

* style: format readme
laib3 pushed a commit to laib3/appium-inspector that referenced this pull request Nov 16, 2024
* docs: correct npm run e2e

* docs: better use npm ci than install

to fully rely on package-lock.json and not possibly modify it unintentionally

* docs: dev uses node-gyp and requires python and c/c++ compiler tools

* fix(test): missing chai.should init, to run given spec only in the ide

* style: format readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants