feat: update Ruby recorder code #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eglitise
added
enhancement
jlipps
approved these changes
Nov 3, 2023
KazuCocoa
reviewed
Nov 4, 2023
KazuCocoa
approved these changes
Nov 5, 2023
| } | ||
|
|
||
| codeFor_rotateDevice () { | ||
| return `# Not supported: rotateDevice`; |
There was a problem hiding this comment.
Not for this issue itself. but maybe we no longer function this method itself.
https://github.com/search?q=org%3Aappium%20mobileRotation&type=code
There was a problem hiding this comment.
Yes, they should likely be replaced with getRotation/setRotation. Not sure if the current drivers implement it though.
shiva-guntoju
pushed a commit
to shiva-guntoju/appium-inspector
that referenced
this pull request
Feb 2, 2024
* feat: update Ruby recorder code * chore: address review comments
laib3
pushed a commit
to laib3/appium-inspector
that referenced
this pull request
Nov 16, 2024
* feat: update Ruby recorder code * chore: address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the recorder-generated code for the Ruby lib core client.
uiautomatorlocator strategyexecuteScriptactivateAppandterminateAppruby_lib_core7.3 to their mobile extension equivalentsmobile: setConnectivityfirst require UI changes