Fix: manually start companion since idb connect cannot do it #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/tools/system-commands.js
Outdated
| @@ -72,9 +74,44 @@ systemCallMethods.connect = async function connect (opts = {}) { | |||
| } | |||
| } | |||
|
|
|||
| let port = DEFAULT_COMPANION_PORT; | |||
There was a problem hiding this comment.
does it work if the companion is already running?
There was a problem hiding this comment.
It works insofar as it kills the running companion.
| try { | ||
| try { | ||
| await tpExec(IDB_EXECUTABLE, ['connect', this.udid]); | ||
| await tpExec(IDB_EXECUTABLE, ['connect', 'localhost', port]); |
There was a problem hiding this comment.
does it also listen on ipv6 (in case localhost is resolved to :::1)?
There was a problem hiding this comment.
I have no idea about that. If it did for connections managed by idb then I imagine it does this way, too.
There was a problem hiding this comment.
I mean if netstat output shows the companion is only listening ipv4 then it is better to explicitly put 127.0.0.1 as the address
There was a problem hiding this comment.
Seems like it does
$ netstat -an -ptcp | grep LISTEN
tcp46 0 0 *.10882 *.* LISTEN
...
imurchie
force-pushed
the
isaac-companion
branch
from
063d47c to
980c6fc
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Letting
idb connectdo the heavy lifting of starting the companion itself does not work. It almost always results in an error likeSo start the companion and then connect to the port it starts on.
This also skips the tests for "describe device" since the underlying command does not support the JSON flag, and parsing the output is the task of another PR