Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo #303

Merged
merged 1 commit into from
Jul 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/finder-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install pylint pytest Appium-Python-Client
- name: Analysing the code with pylint
- name: Analyzing the code with pylint
run: |
cd finder/python
pylint tests/ appium_flutter_finder/
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ This snippet, taken from [example dir](https://github.com/appium-userland/appium
| - | - | -|
| retryBackoffTime | the time wait for socket connection retry for get flutter session (default 3000ms)|500|
| maxRetryCount | the count for socket connection retry for get flutter session (default 30) | 20|
| observatoryWsUri | the URL to attacch to the Dart VM. In general, the flutter driver finds the WebSocket URL from device log such as logcat. You can skip the find the URL steps by specifying this capability. Then, this driver try to establish a session by following the given WebSocket URL. | 'ws://127.0.0.1:60992/aaaaaaaaaaa=/ws' |
| observatoryWsUri | the URL to attach to the Dart VM. In general, the flutter driver finds the WebSocket URL from device log such as logcat. You can skip the find the URL steps by specifying this capability. Then, this driver try to establish a session by following the given WebSocket URL. | 'ws://127.0.0.1:60992/aaaaaaaaaaa=/ws' |

```js
const wdio = require('webdriverio');
Expand Down Expand Up @@ -112,7 +112,7 @@ Legend:
| - | - |
| :white_check_mark: | integrated to CI |
| :ok: | manual tested without CI |
| :warning: | availalbe without manual tested |
| :warning: | available without manual tested |
| :x: | unavailable |

### Finders
Expand Down
8 changes: 4 additions & 4 deletions driver/lib/commands/execute.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const forceGC = async (self: FlutterDriver) => {
isolateId: self.socket!.isolateId,
}) as { type: string };
if (response.type !== `Success`) {
throw new Error(`Could not forceGC, reponse was ${response}`);
throw new Error(`Could not forceGC, response was ${response}`);
}
};

Expand All @@ -114,13 +114,13 @@ const getIsolate = async (self: FlutterDriver, isolateId: string|undefined) => {
}

const anyPromise = (promises: Promise<any>[]) => {
const newpArray = promises.map((p) =>
const newArray = promises.map((p) =>
p.then(
(resolvedValue) => Promise.reject(resolvedValue),
(rejectedReason) => rejectedReason,
),
);
return Promise.all(newpArray).then(
return Promise.all(newArray).then(
(rejectedReasons) => Promise.reject(rejectedReasons),
(resolvedValue) => resolvedValue,
);
Expand All @@ -132,7 +132,7 @@ const clearTimeline = async (self: FlutterDriver) => {
const call2: Promise<any> = self.socket!.call(`clearVMTimeline`);
const response = await anyPromise([call1, call2]);
if (response.type !== `Success`) {
throw new Error(`Could not forceGC, reponse was ${response}`);
throw new Error(`Could not forceGC, response was ${response}`);
}
};

Expand Down
2 changes: 1 addition & 1 deletion driver/lib/driver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ class FlutterDriver extends BaseDriver {
// In WebView context, all request should got to each driver
// so that they can handle http request properly.
// On iOS, WebVie context is handled by XCUITest driver while Android is by chromedriver.
// It measn XCUITest driver should keep the XCUITest driver as a proxy,
// It means XCUITest driver should keep the XCUITest driver as a proxy,
// while UIAutomator2 driver should proxy to chromedriver instead of UIA2 proxy.
return this.proxyWebViewActive && this.proxydriverName !== IOS_DEVICE_NAME;
}
Expand Down
2 changes: 1 addition & 1 deletion finder/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
setup(
name='Appium-Flutter-Finder',
version='0.4.0',
description='An extention of finder for Appium flutter',
description='An extension of finder for Appium flutter',
long_description=io.open(os.path.join(os.path.dirname('__file__'), 'README.md'), encoding='utf-8').read(),
long_description_content_type='text/markdown',
keywords=[
Expand Down