-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix raise an error for launch app and close app since they do not need in espresso #485
Conversation
I don't think launchApp/closeApp have much sense in Espresso, since terminating the app means session termination |
Ah... yeah, sounds reasonable. |
lib/commands/general.js
Outdated
@@ -21,6 +21,16 @@ function assertRequiredOptions (options, requiredOptionNames) { | |||
`You have only provided: ${JSON.stringify(presentOptionNames)}`); | |||
} | |||
|
|||
// eslint-disable-next-line require-await | |||
commands.launchApp = async function launchApp () { | |||
throw new errors.UnsupportedOperationError('Please re-create a new session to configure the app under test correctly'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a new session in order to launch the application under test
lib/commands/general.js
Outdated
|
||
// eslint-disable-next-line require-await | ||
commands.closeApp = async function closeApp () { | ||
throw new errors.UnsupportedOperationError('Please quit the session instead of closeApp'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please quit the session in order to close the application under test
Current
launchApp
missed espresso session like below scenario since espresso-driver does not establish a new session with the launched appThen, below error raises in
find_element
.https://dev.azure.com/kazucocoa/ruby_lib_core/_build/results?buildId=1265