Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ADB helpers to wait for activities #425

Merged
merged 13 commits into from
Apr 1, 2019
Merged

Use ADB helpers to wait for activities #425

merged 13 commits into from
Apr 1, 2019

Conversation

mykola-mokhnach
Copy link
Contributor

Addresses appium/appium#12414

ADB is better in detecting activities than pure instrumentation methods

@dpgraham
Copy link
Contributor

Breaking these tests: https://dev.azure.com/AppiumCI/Appium%20CI/_build/results?buildId=1510&view=logs&jobId=25e09710-041d-5e84-9b7c-7583b448ad52&taskId=e24a952c-7148-505d-9805-c81d8eedb66c&lineStart=84&lineEnd=97&colStart=2&colEnd=89

 17 passing (115ms)
  2 failing

  1) driver
       startEspressoSession
         should call setHiddenApiPolicy:
     TypeError: Cannot read property 'appWaitActivity' of undefined
      at EspressoDriver.appWaitActivity [as startEspressoSession] (lib/driver.js:287:63)

  2) driver
       startEspressoSession
         should not call setHiddenApiPolicy:
     TypeError: Cannot read property 'appWaitActivity' of undefined
      at EspressoDriver.appWaitActivity [as startEspressoSession] (lib/driver.js:287:63)

@mykola-mokhnach
Copy link
Contributor Author

@dpgraham yes I see, working on that.

@mykola-mokhnach
Copy link
Contributor Author

mykola-mokhnach commented Mar 31, 2019 •
edited
Loading

The failing Travis tests seem to be caused by CI slowness

@mykola-mokhnach mykola-mokhnach mentioned this pull request Mar 31, 2019
Closed
@dpgraham
Copy link
Contributor

dpgraham commented Apr 1, 2019

@mykola-mokhnach yep... the AP tests cover the same thing, so I'm fine with committing this.

@dpgraham dpgraham merged commit 0e73f2d into appium:master Apr 1, 2019
@mykola-mokhnach mykola-mokhnach deleted the current_act branch April 2, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgraham dpgraham Awaiting requested review from dpgraham

@imurchie imurchie Awaiting requested review from imurchie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mykola-mokhnach @dpgraham