Add endpoint to flash element on screen #337
Conversation
...o-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/MobileViewFlash.java
Outdated
Show resolved
Hide resolved
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/http/Router.java
Outdated
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/model/ViewFlashParams.java
Outdated
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/model/ViewFlashParams.java
Outdated
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/model/ViewFlashParams.java
Outdated
Show resolved
Hide resolved
...o-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/MobileViewFlash.java
Outdated
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/model/ViewFlashParams.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cool idea @rajdeepv! I'm OK with this as a mobile command. However I wonder if an additional interface might be an Appium setting called flashElementsOnFind or similar, which when set to true causes the flash to happen on each element, whenever it is found. That way users could toggle flashing for whole sections of finding or for a whole test.
But I'm also OK just keeping it as is and treating my idea as a future feature request once we see how people are using this.
|
Thanks, @jlipps. Its good idea and could be immensely helpful during debugging of a failed test and while watching the video of the failed tests. But for now, I will leave it as a mobile command to keep it simple |
...o-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/MobileViewFlash.java
Outdated
Show resolved
Hide resolved
|
@jlipps Yes, we could add an additional argument later to flash on finding if you think it would be useful. |
| view.startAnimation(animation); | ||
| } | ||
| }); | ||
| return null; |
There was a problem hiding this comment.
it was a bit of a surprise to me as a user of this feature that i got control back immediately, before the animation finished. i would have expected to only get control back when the animation was done.
There was a problem hiding this comment.
@jlipps will send a PR soon
Flash the element on the screen. This helps to ensure if we are finding right element