Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Upgrade React to 16, plus upgrade related components #769

Merged
merged 7 commits into from
Dec 14, 2018

Conversation

dpgraham
Copy link
Contributor

  • Upgraded React to 16 and ANTD to 3
  • react-router-redux is deprecated and react-router is outdated, so upgrade those both
  • Had to do some heavy refactoring to get it to work like it did before. Used the latest https://github.com/electron-react-boilerplate/electron-react-boilerplate as my reference point
  • Hot loading was broken before when porting to ParcelJS, now it works again. The router needed to be updated.
  • CSS is broken now. That's why this PR is to have it merged into a separate branch called react-16 and we can break up the upgrade into separate PR's until it's ready to be merged to master.

@dpgraham dpgraham requested a review from jlipps December 12, 2018 23:02
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpgraham i'm not going to have time to really review this in the next week so if you are confident about and want to merge it, go ahead. i'll review and comment here and you/we can make fixes at that point.

@dpgraham dpgraham merged commit acedfd0 into react-16 Dec 14, 2018
@dpgraham dpgraham deleted the dpgraham-react-16-upgrade branch December 14, 2018 04:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants