Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a capability that allows to enforce build tools version #532

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Add a capability that allows to enforce build tools version #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/android-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ helpers.createBaseADB = async function createBaseADB (opts = {}) {
keyAlias,
keyPassword,
remoteAppsCacheLimit,
buildToolsVersion,
} = opts;
return await ADB.createADB({
adbPort,
Expand All @@ -77,6 +78,7 @@ helpers.createBaseADB = async function createBaseADB (opts = {}) {
keyAlias,
keyPassword,
remoteAppsCacheLimit,
buildToolsVersion,
});
};

Expand Down
5 changes: 4 additions & 1 deletion lib/desired-caps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,10 @@ let commonCapConstraints = {
},
remoteAppsCacheLimit: {
isNumber: true
}
},
buildToolsVersion: {
isString: true
},
};

let uiautomatorCapConstraints = {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
],
"dependencies": {
"@babel/runtime": "^7.0.0",
"appium-adb": "^7.6.0",
"appium-adb": "^7.7.0",
"appium-base-driver": "^3.15.5",
"appium-chromedriver": "^4.8.0",
"appium-support": "^2.25.0",
Expand Down
2 changes: 2 additions & 0 deletions test/unit/android-helper-specs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ describe('Android Helpers', function () {
keyAlias: 'keyAlias',
keyPassword: 'keyPassword',
remoteAppsCacheLimit: 5,
buildToolsVersion: '1.2.3',
});
ADB.createADB.calledWithExactly({
adbPort: '222',
Expand All @@ -287,6 +288,7 @@ describe('Android Helpers', function () {
keyAlias: 'keyAlias',
keyPassword: 'keyPassword',
remoteAppsCacheLimit: 5,
buildToolsVersion: '1.2.3',
}).should.be.true;
curDeviceId.should.equal('111222');
emulatorPort.should.equal('111');
Expand Down